Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monitor] Old ESLint cleanup #11613

Merged
merged 1 commit into from
Oct 6, 2020
Merged

[Monitor] Old ESLint cleanup #11613

merged 1 commit into from
Oct 6, 2020

Conversation

deyaaeldeen
Copy link
Member

@deyaaeldeen deyaaeldeen commented Oct 2, 2020 •
edited
Loading

  • deletes eslint plugin packages that were needed for the old approach for linting still listed as dependencies in our package.json files. See ESLint configuration cleanup #11528.
  • eslint-plugin-import is deleted because it was not being used.
  • making .eslintrc.json leaner by deleting stuff overlapping with the base config.

This change does not change the output of rushx lint.

@ghost ghost added the Monitor Monitor, Monitor Ingestion, Monitor Query label Oct 2, 2020
@deyaaeldeen deyaaeldeen merged commit 025e308 into Azure:master Oct 6, 2020
@deyaaeldeen deyaaeldeen deleted the monitor-cleanup branch October 6, 2020 17:57
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Nov 18, 2020
CodeGen from PR 11613 in Azure/azure-rest-api-specs
053ab12 
Change PartitionOption to object to allow expression (Azure#11613)

* add httpRequestTimeout to odata based connector activities

* add httpRequestTimeout to odata based connector activities

* add sql parallel read properties

* change partitionOption to object

* change ParallelOption to object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markwolff markwolff markwolff approved these changes

@ramya-rao-a ramya-rao-a ramya-rao-a approved these changes

@xirzec xirzec Awaiting requested review from xirzec

Assignees
No one assigned
Labels
Monitor Monitor, Monitor Ingestion, Monitor Query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deyaaeldeen @markwolff @ramya-rao-a