Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate rush's shrinkwrap file #11621

Merged
merged 5 commits into from
Oct 14, 2020

Conversation

deyaaeldeen
Copy link
Member

@deyaaeldeen deyaaeldeen commented Oct 2, 2020

I just did:

  • rm common/config/rush/pnpm-lock.yaml
  • rush update

I think it is worth looking at a fresh regeneration. Or should we not have it checked-in at all?

@willmtemple
Copy link
Contributor

FYI you can accomplish the same thing with rush update --full. It looks like we pulled in a dep here that makes use of optional catch binding, not available in Node 8.

@deyaaeldeen
Copy link
Member Author

@willmtemple thanks for the tip! I created this issue: #11666.

Copy link
Contributor

@willmtemple willmtemple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with doing this as long as Engineering Systems approves. It'd be good to just run a few of our test pipelines on this PR as well.

@deyaaeldeen
Copy link
Member Author

/azp run js - storage-blob - tests

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@mikeharder
Copy link
Member

/azp list

@azure-pipelines
Copy link

No pipelines found for this repository.

@mikeharder
Copy link
Member

/azp run js - core - ci

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@mikeharder
Copy link
Member

/azp list

@azure-pipelines
Copy link

No pipelines found for this repository.

@mikeharder
Copy link
Member

/azp list

@azure-pipelines
Copy link

CI/CD Pipelines for this repository:

@mikeharder
Copy link
Member

/azp run js - storage-blob - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@deyaaeldeen
Copy link
Member Author

/azp run js - text-analytics - tests

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@deyaaeldeen
Copy link
Member Author

/azp run js - textanalytics - tests

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@deyaaeldeen
Copy link
Member Author

/azp list

@azure-pipelines
Copy link

No pipelines found for this repository.

@deyaaeldeen
Copy link
Member Author

@mikeharder azp is acting weird again.

@ramya-rao-a
Copy link
Contributor

@deyaaeldeen What are the next steps here? Anything blocking the PR?

@deyaaeldeen
Copy link
Member Author

@ramya-rao-a The next step is to run the text analytics test in CI here but I am not able to, @mikeharder could you please do it?

@praveenkuttappan
Copy link
Member

/azp run js - textanalytics - ci

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@mikeharder
Copy link
Member

/azp where

@azure-pipelines
Copy link

Azure DevOps orgs getting events for this repository:

@mikeharder
Copy link
Member

/azp list

@azure-pipelines
Copy link

CI/CD Pipelines for this repository:

@praveenkuttappan
Copy link
Member

This change is not in trigger list for text analytics.

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@deyaaeldeen
Copy link
Member Author

/azp run js - textanalytics - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@deyaaeldeen deyaaeldeen merged commit 51cda73 into Azure:master Oct 14, 2020
@deyaaeldeen deyaaeldeen deleted the freshen-up-shrinkwrap branch October 14, 2020 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants