Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in README.md and Javascript samples for Azure Tables #11632

Merged
2 commits merged into from
Oct 6, 2020

Conversation

piraces
Copy link
Contributor

@piraces piraces commented Oct 3, 2020

Closes #11489

  • As the issue states, there are some unneeded exports in the Javascript samples for Azure Tables that have been removed.
  • As reported by @joheredi , the following replacements in the README.md have been done (identified as a bug): entity.PartitionKey to entity.partitionKey and entity.RowKey to entity.rowKey.
  • Also a little typo in the README.md in the same section has been fixed.

@piraces piraces requested a review from joheredi as a code owner October 3, 2020 13:01
@ghost ghost added Tables customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Oct 3, 2020
@ghost
Copy link

ghost commented Oct 3, 2020

Thank you for your contribution piraces! We will review the pull request and get back to you soon.

Copy link
Member

@joheredi joheredi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@piraces the PR looks great! Thanks for your contribution it is much appreciated! 😄

Would you mind updating the Typescript samples to remove un-needed exports from there as well?

@piraces
Copy link
Contributor Author

piraces commented Oct 5, 2020

Ok I will make a commit for it too 🙂

@piraces
Copy link
Contributor Author

piraces commented Oct 6, 2020

@joheredi I have made a commit updating the Typescript samples to remove un-needed exports from there as well 👍

Copy link
Member

@joheredi joheredi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your help fixing these issues, we really appreciate it!

@ghost
Copy link

ghost commented Oct 6, 2020

Hello @joheredi!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 2fc97d9 into Azure:master Oct 6, 2020
@piraces piraces deleted the azure-tables-samples-readme-fixes branch October 6, 2020 17:11
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Tables
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Tables Readme And Sample Issue
2 participants