[Batch] update tests #11836
Merged
[Batch] update tests #11836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ramya-rao-a
suggested changes
Oct 15, 2020
bgklein
reviewed
Oct 15, 2020
| result = await client.pool.get("nodesdktestpool1"); | ||
| metadata = result.metadata![0]; | ||
| if (result.allocationState === "resizing") { | ||
| await wait(10000); |
There was a problem hiding this comment.
You should not wait. You should probably poll the expected state and then timeout if it doesn't reach it in the specified time.
ramya-rao-a
approved these changes
Oct 15, 2020
deyaaeldeen
commented
Oct 15, 2020
|
@xingwu1 Can you do a run of the tests for this package and confirm that we are good to go? After that we can look into releasing this package. |
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Dec 8, 2020
Add new DevOps API swagger (Azure#11836) * Add new DevOps API swagger * Fix SDK error * updating swagger version 2020-08-01-preview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compile errors in the batch test suite after regenerating using the latest swagger. The test suite runs all green now.