Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core-https] Fix some issues with streams in NodeHttpsClient #11929

Merged
merged 1 commit into from
Oct 20, 2020
Merged

[core-https] Fix some issues with streams in NodeHttpsClient #11929

merged 1 commit into from
Oct 20, 2020

Conversation

xirzec
Copy link
Member

@xirzec xirzec commented Oct 19, 2020

Node 14 changed how streams propagate errors so that they're always async. This revealed some issues in how we use streams for upload/download reporting during error conditions.

Fixes #11919

@xirzec
Fix some issues with streams.
ecf42c1 
Node 14 changed how streams propagate errors so that they're always async.

Fixes Azure#11919
@xirzec xirzec added Client This issue points to a problem in the data-plane of the library. Azure.Core labels Oct 19, 2020
@xirzec xirzec self-assigned this Oct 19, 2020
mikeharder
mikeharder approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@mikeharder mikeharder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you might want a review from someone on the JS team as well.

@xirzec
Copy link
Member Author

xirzec commented Oct 20, 2020

LGTM, but you might want a review from someone on the JS team as well.

@joheredi 👀

joheredi
joheredi approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@joheredi joheredi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

jeremymeng
jeremymeng approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@jeremymeng jeremymeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xirzec xirzec merged commit ff0ac51 into Azure:master Oct 20, 2020
@xirzec xirzec deleted the fixStreamIssues branch October 20, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremymeng jeremymeng jeremymeng approved these changes

@mikeharder mikeharder mikeharder approved these changes

@joheredi joheredi joheredi approved these changes

@bterlson bterlson Awaiting requested review from bterlson

@ramya-rao-a ramya-rao-a Awaiting requested review from ramya-rao-a

Assignees

@xirzec xirzec

Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[core-https] "write after end" test failure on Node 14
4 participants
@xirzec @jeremymeng @mikeharder @joheredi