[Service Bus] subQueue -> subQueueType #12223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
requested review from
chradek,
HarshaNalluru and
richardpark-msft
as code owners
ghost
added
the
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Should we do the same for ReceiveMode i.e. inline it instead of having a dedicated type? |
HarshaNalluru
approved these changes
Nov 2, 2020
Having an alias(or dedicated type) helps in reusing it wherever we declare the |
richardpark-msft
approved these changes
Nov 2, 2020
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Jan 18, 2021
syncing changes from 2020-06-01-preview api (Azure#12462) * [2020-06-01-preview] Update namedvalue add refreshSecret operation (Azure#12223) * add refreshSecret * addressing comments * add 202 * address comments * parenthesis Co-authored-by: Kacie Kang <jikang@microsoft.com> * [2020-06-01-preview] Update certificate add refreshSecret operation (Azure#12226) * add refresh * add path * add keyvault part * address comments Co-authored-by: Kacie Kang <jikang@microsoft.com> Co-authored-by: Kacie Kang <jikang@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike other languages, we don not use enums and use string literals instead. For the
subQueueproperty, this opens up a potential confusion for people if they think they can pass in queue names. To help with this, in this PR wesubQueuetosubQueueType