Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync eng/common directory with azure-sdk-tools for PR 1170 #12339

Merged
merged 2 commits into from
Nov 12, 2020

Conversation

azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#1170 See eng/common workflow

@azure-sdk azure-sdk requested a review from sima-zhu November 6, 2020 19:49
@azure-sdk azure-sdk added Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system. labels Nov 6, 2020
@azure-sdk azure-sdk force-pushed the sync-eng/common-preprocess-1170 branch 3 times, most recently from a65da21 to 1e2ca85 Compare November 7, 2020 01:20
@check-enforcer
Copy link

check-enforcer bot commented Nov 7, 2020

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run js - [service] - ci

@azure-sdk azure-sdk force-pushed the sync-eng/common-preprocess-1170 branch 7 times, most recently from 841fcdb to 93204b6 Compare November 11, 2020 23:56
@azure-sdk azure-sdk force-pushed the sync-eng/common-preprocess-1170 branch from 93204b6 to 23318d7 Compare November 12, 2020 00:45
@azure-sdk azure-sdk merged commit c23212d into master Nov 12, 2020
@azure-sdk azure-sdk deleted the sync-eng/common-preprocess-1170 branch November 12, 2020 01:53
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Jan 11, 2021
add managedVirtualNetwork reference to IR (Azure#12339)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants