-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[telemetry] Centralize (as much as is practical) the creation of spans to ease upgrades #13887
[telemetry] Centralize (as much as is practical) the creation of spans to ease upgrades #13887
Commits on Feb 19, 2021
-
Centralize createSpan code into core-tracing, update the minimum need…
…ed for core-tracing to compile and test
Configuration menu - View commit details
-
Copy full SHA for 2ccc04f - Browse repository at this point
Copy the full SHA 2ccc04fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d00744f - Browse repository at this point
Copy the full SHA d00744fView commit details -
Updating the package reference to be the new core-tracing version (wh…
…ich will shortly have a new OT)
Configuration menu - View commit details
-
Copy full SHA for 96f7c97 - Browse repository at this point
Copy the full SHA 96f7c97View commit details -
Configuration menu - View commit details
-
Copy full SHA for 13d5b35 - Browse repository at this point
Copy the full SHA 13d5b35View commit details -
Configuration menu - View commit details
-
Copy full SHA for 450e1ba - Browse repository at this point
Copy the full SHA 450e1baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 88b5783 - Browse repository at this point
Copy the full SHA 88b5783View commit details -
Centralize most of the createSpan logic (except for keyvault, which i…
…s a bit more complicated)
Configuration menu - View commit details
-
Copy full SHA for 724092a - Browse repository at this point
Copy the full SHA 724092aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7092a57 - Browse repository at this point
Copy the full SHA 7092a57View commit details -
Service Bus was using the properties from createSpan() with a differe…
…nt name. Not sure why I didn't see this earlier.
Configuration menu - View commit details
-
Copy full SHA for df7f0e1 - Browse repository at this point
Copy the full SHA df7f0e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for cca3325 - Browse repository at this point
Copy the full SHA cca3325View commit details
Commits on Feb 20, 2021
-
Remove unneeded OperationTracingOptionsLike (the same package already…
… had OperationTracingOptions!)
Configuration menu - View commit details
-
Copy full SHA for 89da87e - Browse repository at this point
Copy the full SHA 89da87eView commit details -
Configuration menu - View commit details
-
Copy full SHA for fd10725 - Browse repository at this point
Copy the full SHA fd10725View commit details -
identity: the deconstructed names are different (and null checks need…
… to be propagated)
Configuration menu - View commit details
-
Copy full SHA for b00a413 - Browse repository at this point
Copy the full SHA b00a413View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee2b382 - Browse repository at this point
Copy the full SHA ee2b382View commit details -
Update storage-blob for the pending update to the latest OpenTelemetr…
…y. Prior to this change `createSpan` would create a new SpanOptions, out of a OperationTracingOptions (basically). This works today but will break when we move to a later version of opentelemetry, where the necessary information to track is actually two separate fields. To make this simpler we have a createSpanFunction that can handle doing the proper updating of the `tracingOptions ` property of an OperationOptions compatible type. Converting any code over to this style should future proof us a bit. In storage-blob the changes I've made here are: - If the call takes an OperationOptions, try to pass the updatedOptions directly, or if extensive copying/mutation was occuring - just pass operationOptions.tracingOptions instead. So this code: ``` { ...options, tracingOptions: { ...options!.tracingOptions, spanOptions } } ``` Becomes ``` updatedOptions (which came back from core-tracing's createSpan function) ``` - If the underlying call takes RequestOptionsBase then we call ...convertTracingToRequestOptionsBase(updatedOptions) which should allow me room to just change _that_ function when the number of fields to copy over changes.
Configuration menu - View commit details
-
Copy full SHA for 2aea35c - Browse repository at this point
Copy the full SHA 2aea35cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4dc72d8 - Browse repository at this point
Copy the full SHA 4dc72d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 42ff058 - Browse repository at this point
Copy the full SHA 42ff058View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f99488 - Browse repository at this point
Copy the full SHA 6f99488View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee8c6f0 - Browse repository at this point
Copy the full SHA ee8c6f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7edc5dd - Browse repository at this point
Copy the full SHA 7edc5ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 63b013d - Browse repository at this point
Copy the full SHA 63b013dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 68c5ce0 - Browse repository at this point
Copy the full SHA 68c5ce0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7031b79 - Browse repository at this point
Copy the full SHA 7031b79View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bd5363 - Browse repository at this point
Copy the full SHA 4bd5363View commit details
Commits on Feb 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b9c51e6 - Browse repository at this point
Copy the full SHA b9c51e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6365b72 - Browse repository at this point
Copy the full SHA 6365b72View commit details -
Configuration menu - View commit details
-
Copy full SHA for f645aec - Browse repository at this point
Copy the full SHA f645aecView commit details -
- createSpa now guarantees it's return value is not null (eliminates …
…some more code doing <blah> || {} - synapse-artifacts: fixing a .tracingOptions slicing issue where RequestOptionsBase was being passed to createSpan, which expected an OperationOptions.
Configuration menu - View commit details
-
Copy full SHA for 4b0e99e - Browse repository at this point
Copy the full SHA 4b0e99eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3404d31 - Browse repository at this point
Copy the full SHA 3404d31View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7887702 - Browse repository at this point
Copy the full SHA 7887702View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a71f92 - Browse repository at this point
Copy the full SHA 5a71f92View commit details -
Configuration menu - View commit details
-
Copy full SHA for e86b11d - Browse repository at this point
Copy the full SHA e86b11dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 36e30c1 - Browse repository at this point
Copy the full SHA 36e30c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e3fada - Browse repository at this point
Copy the full SHA 5e3fadaView commit details -
Configuration menu - View commit details
-
Copy full SHA for fc4e05f - Browse repository at this point
Copy the full SHA fc4e05fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3785e5e - Browse repository at this point
Copy the full SHA 3785e5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 00cbaba - Browse repository at this point
Copy the full SHA 00cbabaView commit details -
our semver rule was tripping over using preview.10 as the version. Ju…
…st switching over to -beta.1, which is what it as upgraded to originally.
Configuration menu - View commit details
-
Copy full SHA for 81d17b7 - Browse repository at this point
Copy the full SHA 81d17b7View commit details
Commits on Feb 23, 2021
-
Bring back a compatible createSpan function so we don't cause runtime…
… issues in already released packages that might upgrade to this core-http version.
Configuration menu - View commit details
-
Copy full SHA for b48f98c - Browse repository at this point
Copy the full SHA b48f98cView commit details -
After talking with @joheredi it's obvious we can't remove this functi…
…on as it'd cause errors in existing packages that update to the latest core-http. Will have to reserve for a major version update.
Configuration menu - View commit details
-
Copy full SHA for 5cf9288 - Browse repository at this point
Copy the full SHA 5cf9288View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b5e2d6 - Browse repository at this point
Copy the full SHA 0b5e2d6View commit details -
Change name from SpanConfig (which is too generic!) to CreateSpanFunc…
…tionArgs, which is hyper-specific and cannot be confused for anything but the arguments for createSpanFunction Also, added some doc comments to createSpanFunction
Configuration menu - View commit details
-
Copy full SHA for bd1a4e8 - Browse repository at this point
Copy the full SHA bd1a4e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for b168a32 - Browse repository at this point
Copy the full SHA b168a32View commit details -
Configuration menu - View commit details
-
Copy full SHA for bed4e50 - Browse repository at this point
Copy the full SHA bed4e50View commit details -
Configuration menu - View commit details
-
Copy full SHA for af57992 - Browse repository at this point
Copy the full SHA af57992View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf06056 - Browse repository at this point
Copy the full SHA bf06056View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e3b80f - Browse repository at this point
Copy the full SHA 0e3b80fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4900eb1 - Browse repository at this point
Copy the full SHA 4900eb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for caf7f63 - Browse repository at this point
Copy the full SHA caf7f63View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f7ecc5 - Browse repository at this point
Copy the full SHA 7f7ecc5View commit details
Commits on Feb 24, 2021
-
Configuration menu - View commit details
-
Copy full SHA for fe61219 - Browse repository at this point
Copy the full SHA fe61219View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8dd23b - Browse repository at this point
Copy the full SHA d8dd23bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f62518 - Browse repository at this point
Copy the full SHA 8f62518View commit details -
Configuration menu - View commit details
-
Copy full SHA for fce3238 - Browse repository at this point
Copy the full SHA fce3238View commit details -
Configuration menu - View commit details
-
Copy full SHA for 72d141f - Browse repository at this point
Copy the full SHA 72d141fView commit details