Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search Code Changes for April Release #14620

Merged
merged 4 commits into from
Apr 2, 2021
Merged

Search Code Changes for April Release #14620

merged 4 commits into from
Apr 2, 2021

Conversation

sarangan12
Copy link
Member

@xirzec This PR is for the April Release of Search SDK:

The following Issues are all related to regeneration of the SDK and modifying the custom layer accordingly:

  1. Add support for additional skills #13968
  2. Add new data source support for ADLS Gen2 #13902
  3. Add support for normalizers #13969

This issue is a minor issue which deals with changing a data type.

  1. [Azure-Search] Improve typing for SearchResult #12962

Please review this PR.

@ghost ghost added the Search label Mar 30, 2021
xirzec
xirzec approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@xirzec xirzec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mostly okay with this change, but I don't like that we have a public surface that ambiguously contains both null and undefined - are we doing partial updates where undefined means 'leave as is' and null means 'remove'?

sdk/search/search-documents/review/search-documents.api.md
@@ -216,7 +219,7 @@ export type ConditionalSkill = BaseSearchIndexerSkill & {
// @public
export interface CorsOptions {
allowedOrigins: string[];
maxAgeInSeconds?: number;
maxAgeInSeconds?: number | null;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does the behavior for null differ from the previous behavior for undefined?

sdk/search/search-documents/review/search-documents.api.md
@@ -272,6 +275,50 @@ export interface CustomAnalyzer {
tokenizerName: string;
}

// @public
export interface CustomEntity {
accentSensitive?: boolean | null;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question throughout - seems like we wouldn't need to support both null and undefined

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am working on removing it with the generator. Will be removed soon.

@sarangan12 sarangan12 merged commit 61fcbd4 into Azure:master Apr 2, 2021
jay-most pushed a commit to jay-most/azure-sdk-for-js that referenced this pull request Apr 26, 2021
@sarangan12 @vindicatesociety
Search Code Changes for April Release (Azure#14620)
b70a09f 
* Search Code Changes for April Release

* Updated Version, Changelog & Regened to latest SHA

* Update Perf Test Dependency
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Aug 26, 2021
@Nilambari @abhi7860
@Syair @Wistlie @wangxu724 @guptas14 @akshaysngupta @litchiyangMSFT @nagula-ritvika @davelasc @b564518128 @tinawu6 @irrogozh
CodeGen from PR 15709 in Azure/azure-rest-api-specs
56ce470 
Mitryakh/network march (Azure#15709)

* Adds base for updating Microsoft.Network from version stable/2021-02-01 to version 2021-03-01

* Updates readme

* Updates API version in new specs and examples

* Add new parameter to enable/disable BGP route translation for NAT VirtualWan VpnGateway (Azure#14462)

* Adding Bastion Host Configuration Features (Azure#14442)

Co-authored-by: Abhishek Shah <shabhis@microsoft.com>

* Add PL ASG (Azure#14620)

* Add PL ASG

* Prettier

* [Private Link] Private Endpoint Ipconfigurations swagger for 2021-03-01 (Azure#14662)

* Ipconfigurations swagger

* Ran prettier check

* fixing conflicting files

* fixing lint

* Fixing linter diff

* Lint diff

* resolving comments

* fixing conflict

* Fioxing

* running prettier

* Fixing linter comment

Co-authored-by: Shane Baden <shbaden@microsoft.com>

* Add missing properties of ServiceEndpointPolicy (Azure#14948)

* Add missing 'type' and 'serviceAlias' for ServiceEndpointPolicy related API response

* Add missing 'contextualServiceEndpointPolicies'

* fix bug

* fix type

* Add missing properties to ServiceEndpointPolicy

* Revert "fix type"

This reverts commit 3a49beb66d9bbb288fa0d3baaeaf5aaf2bbc6ee9.

* Revert "fix bug"

This reverts commit a4fff4ae925b01ed0cfb07b1594fb95e2c6649c7.

* Revert "Add missing 'contextualServiceEndpointPolicies'"

This reverts commit ccf19167abc61b90bce6b5204dc3b2a64fdf4ca4.

* Revert "Add missing 'type' and 'serviceAlias' for ServiceEndpointPolicy related API response"

This reverts commit e532cc1118241a74902e4362c32c25c11a764933.

Co-authored-by: Xu Wang <wax@microsoft.com>

* add new service tag details api (Azure#14958)

* add new service tag details api

* prettier check fixes

* fixing lint issue, additional properties issue

* Add Load distribution policy and global configuration to AppGW (Azure#14790)

* add Load distribution policy and global configuration to Application Gateway resource

* prettify

* remove provisioning state

* add public ssh key to network virtual appliance (Azure#14988)

* Changes needed for BgpEndpoint (Azure#14800)

* changes needed for BgpEndpoint

* prettier check

* model validation fix

* fix description

* update again

* Multi QoS support for DSCP configuration (Azure#15120)

* Updating the DSCP jsons to reflect the  multi-qos support

* Adding support to multi-qos

* adding the type object to NrpQos

* fixing the prettier
removing my update to the settings

* fixing the missing type object error. seeing if this also fixes the additional attributes exception

* fixing the prettier exception

* almost forgot this, it was refactor from NrpQos to QosDefinition. NRPQos is already being used in Networking repo

* copying what I did with my other objects

* names didn't match with what I have in NRP's src

* forgot to update the examples with the updates in the specification. updating it

* fixing the merge exceptions

* Add SQL Setting to Firewall Policy (Azure#15110)

* Add SQL Setting to Firewall Policy

* fix lint check except for object type

* resolve linter error

* network: fix newly added targets field to an array and missing sub-resource properties in applicationGateways.json (Azure#15318)

* fix: change target to an array and add subresource properties

* fix target examples

* Support to update tags for BastionHost resource (Azure#15446)

* Initial commit

* Validation fixes

* Update bastionHost.json

Co-authored-by: Abhishek Shah <shabhis@microsoft.com>

* Azure FW - Explicit Proxy feature swagger change (Azure#15017)

* explicit proxy swagger change

* prettier check fix

* lint check

* prettier fix

* revert unnecessary file change

* Add kind to virtual hub (Azure#15562)

* Adding customnetworkinterfacename attribute to Private Endpoint (Azure#15574)

Co-authored-by: Shane Baden <shbaden@microsoft.com>

* Added 3 new properties to InboundNatRule resource (Azure#15611)

* Added the missins properties to fix the change breaking update (Azure#15732)

Co-authored-by: Nilambari <nilamd@microsoft.com>
Co-authored-by: Abhishek Shah <shah.abhi7860@gmail.com>
Co-authored-by: Abhishek Shah <shabhis@microsoft.com>
Co-authored-by: Yang Shi <yangshi93@gmail.com>
Co-authored-by: Shane Baden <naruto.shane@gmail.com>
Co-authored-by: Shane Baden <shbaden@microsoft.com>
Co-authored-by: Xu Wang <wangxu724@gmail.com>
Co-authored-by: Xu Wang <wax@microsoft.com>
Co-authored-by: guptas14 <71726901+guptas14@users.noreply.github.com>
Co-authored-by: Akshay Gupta <aksgupta@microsoft.com>
Co-authored-by: litchiyangMSFT <64560090+litchiyangMSFT@users.noreply.github.com>
Co-authored-by: Ritvika Reddy Nagula <rinagula@microsoft.com>
Co-authored-by: David Velasco <davelasc@microsoft.com>
Co-authored-by: Jiejiong Wu <b564518128@users.noreply.github.com>
Co-authored-by: tinawu6 <78238424+tinawu6@users.noreply.github.com>
Co-authored-by: irrogozh <irrogozh@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xirzec xirzec xirzec approved these changes

@bterlson bterlson Awaiting requested review from bterlson

@chradek chradek Awaiting requested review from chradek

Assignees
No one assigned
Labels
Search
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarangan12 @xirzec