-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Smoke Tests] Skip smoke tests until the samples/setup is fixed for them #14792
[Smoke Tests] Skip smoke tests until the samples/setup is fixed for them #14792
Conversation
"//sampleConfiguration": { "skipFolder": true },
/azp run js - smoke-tests |
Azure Pipelines successfully started running 1 pipeline(s). |
This reverts commit 3dd79f3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have ETA on when could resolve the configuration issue in pipeline?
Please also reference to this PR in the future PR to bring these samples back in smoke test,
@EmmaZhu Some of the samples that used to succeed before started to fail, I've retriggered the pipeline to see if this was a flaky issue of the pipeline. Need more investigation before merging this PR. |
cc @witemple-msft, @benbp |
Somehow the resources in the pipeline ended up bad though the samples/test resources/yml scripts didn't change for the past few days. Worth investigating the pipeline and fixing it rather than disabling every package in this PR. |
Owners were not pinged for "communication" at #14792 As @ramya-rao-a suggested, reverting #13809 until the group alias is fixed. This reverts commit 67dc66b. /cc @meeraharidasa
Closing as @jeremymeng is working on fixing the pipeline with ENG SYS. |
Owners were not pinged for "communication" at Azure#14792 As @ramya-rao-a suggested, reverting Azure#13809 until the group alias is fixed. This reverts commit 67dc66b. /cc @meeraharidasa
Logged individual issues for the packages
#14788
#14789
#14790
#14791
The samples corresponding to these packages are failing in the smoke test pipeline because the resources setup is not done properly.
This PR attempts to skip running the smoke tests for these packages until the resource issues are resolved.
We'll need to enable them back once the individual issues are resolved.