Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Smoke Tests] Skip smoke tests until the samples/setup is fixed for them #14792

Conversation

HarshaNalluru
Copy link
Member

@HarshaNalluru HarshaNalluru commented Apr 7, 2021

Logged individual issues for the packages
#14788
#14789
#14790
#14791

The samples corresponding to these packages are failing in the smoke test pipeline because the resources setup is not done properly.

This PR attempts to skip running the smoke tests for these packages until the resource issues are resolved.
We'll need to enable them back once the individual issues are resolved.

@ghost ghost added Communication Service Bus KeyVault Storage Storage Service (Queues, Blobs, Files) labels Apr 7, 2021
@HarshaNalluru
Copy link
Member Author

/azp run js - smoke-tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This reverts commit 3dd79f3.
Copy link
Member

@EmmaZhu EmmaZhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have ETA on when could resolve the configuration issue in pipeline?

Please also reference to this PR in the future PR to bring these samples back in smoke test,

@HarshaNalluru
Copy link
Member Author

@EmmaZhu Some of the samples that used to succeed before started to fail, I've retriggered the pipeline to see if this was a flaky issue of the pipeline.
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=831278&view=logs&j=f3570516-c8fe-5ce9-92b2-b737df25d5ea

Need more investigation before merging this PR.
I'll keep the individual issues open until the pipeline is green.

@ramya-rao-a
Copy link
Contributor

cc @witemple-msft, @benbp

@HarshaNalluru
Copy link
Member Author

Somehow the resources in the pipeline ended up bad though the samples/test resources/yml scripts didn't change for the past few days.

Worth investigating the pipeline and fixing it rather than disabling every package in this PR.
@witemple-msft @benbp

ghost pushed a commit that referenced this pull request Apr 8, 2021
Owners were not pinged for "communication" at #14792


As @ramya-rao-a suggested, reverting #13809 until the group alias is fixed. 

This reverts commit 67dc66b.

/cc @meeraharidasa
@HarshaNalluru
Copy link
Member Author

Closing as @jeremymeng is working on fixing the pipeline with ENG SYS.

jay-most pushed a commit to jay-most/azure-sdk-for-js that referenced this pull request Apr 26, 2021
Owners were not pinged for "communication" at Azure#14792


As @ramya-rao-a suggested, reverting Azure#13809 until the group alias is fixed. 

This reverts commit 67dc66b.

/cc @meeraharidasa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Communication KeyVault Service Bus Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants