[Communication][Chat] Changes required for min-max testing #14942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armansabaa
requested review from
0rland0Wats0n,
ankitarorabit,
DominikMe and
a team
as code owners
ghost
added
the
|
The test segregations look good to me. To enable the min-max tests, we need to remove the filter - https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/communication/communication-chat/tests.yml#L9 Once you do this, you will see two additional jobs running in the test pipeline - one for min versions and one for max versions |
|
/azp run js - communication-chat - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…sabaa/azure-sdk-for-js; branch 'master' of https://github.com/Azure/azure-sdk-for-js into abelsaba_minmaxtestng_chat
beltr0n
requested changes
Apr 20, 2021
sdk/communication/communication-chat/test/public/chatThreadClient.mocked.spec.ts
Outdated
Show resolved
Hide resolved
sdk/communication/communication-chat/test/public/utils/mockClient.ts
Outdated
Show resolved
Hide resolved
sdk/communication/communication-chat/test/public/chatClient.mocked.spec.ts
Outdated
Show resolved
Hide resolved
beltr0n
requested changes
Apr 20, 2021
|
/azp run js - communication-chat - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
LuChen-Microsoft
approved these changes
Apr 20, 2021
beltr0n
approved these changes
Apr 21, 2021
jay-most
pushed a commit
to jay-most/azure-sdk-for-js
that referenced
this pull request
Apr 26, 2021
* Moving tests under public folder * enabling minmax jobs * disabling minmax test for now * moving files referencing generated under /internal * nit fix command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following steps illustrated here #13816.