-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for the getPolicy, setPolicy, and resetPolicy APIs #15432
Merged
LarryOsterman
merged 14 commits into
Azure:master
from
LarryOsterman:LarryO-AddedGetPolicy
Jun 2, 2021
Merged
Added support for the getPolicy, setPolicy, and resetPolicy APIs #15432
LarryOsterman
merged 14 commits into
Azure:master
from
LarryOsterman:LarryO-AddedGetPolicy
Jun 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p to use correct shared attestation provider; other fixes
deyaaeldeen
reviewed
May 27, 2021
deyaaeldeen
reviewed
May 27, 2021
deyaaeldeen
reviewed
May 27, 2021
deyaaeldeen
reviewed
May 27, 2021
deyaaeldeen
reviewed
May 27, 2021
deyaaeldeen
reviewed
May 27, 2021
LarryOsterman
changed the title
Added support for the getPolicy API
Added support for the getPolicy, setPolicy, and resetPolicy APIs
May 28, 2021
/azp run js - attestation - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
deyaaeldeen
reviewed
Jun 1, 2021
deyaaeldeen
reviewed
Jun 1, 2021
sdk/attestation/attestation/src/attestationAdministrationClient.ts
Outdated
Show resolved
Hide resolved
deyaaeldeen
reviewed
Jun 1, 2021
deyaaeldeen
reviewed
Jun 1, 2021
deyaaeldeen
reviewed
Jun 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I finished reviewing latest changes and left a few comments.
deyaaeldeen
reviewed
Jun 2, 2021
deyaaeldeen
reviewed
Jun 2, 2021
sdk/attestation/attestation/src/attestationAdministrationClient.ts
Outdated
Show resolved
Hide resolved
deyaaeldeen
reviewed
Jun 2, 2021
deyaaeldeen
reviewed
Jun 2, 2021
sdk/attestation/attestation/src/attestationAdministrationClient.ts
Outdated
Show resolved
Hide resolved
deyaaeldeen
reviewed
Jun 2, 2021
deyaaeldeen
reviewed
Jun 2, 2021
deyaaeldeen
approved these changes
Jun 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Jul 29, 2021
track1 add batch tag machine learning services in readme.go.md (Azure#15432) * track1 add batch tag machine learning services in readme.go.md * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the policy family of APIs.
Also restructured a bunch of code to make things cleaner, added more properties to AttestationToken class; Cleaned up tra