Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core-rest-pipeline] 1.1.0 #15502

Closed
wants to merge 5 commits into from
Closed

[core-rest-pipeline] 1.1.0 #15502

wants to merge 5 commits into from

Conversation

sadasant
Copy link
Contributor

@sadasant sadasant commented Jun 1, 2021 •
edited by deyaaeldeen
Loading

This PR updates the changelog and the package.json to release 1.1.0 on Thursday.

@sadasant sadasant self-assigned this Jun 1, 2021
@sadasant sadasant marked this pull request as ready for review June 2, 2021 00:15
deyaaeldeen
deyaaeldeen approved these changes Jun 2, 2021
View reviewed changes
Copy link
Member

@deyaaeldeen deyaaeldeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sadasant sadasant requested a review from xirzec June 2, 2021 00:24
@sadasant
Copy link
Contributor Author

sadasant commented Jun 2, 2021

I missed the obvious! I’ll be back

@sadasant
Copy link
Contributor Author

sadasant commented Jun 2, 2021

@xirzec , @jeremymeng I’ll wait for you both

@ramya-rao-a
Copy link
Contributor

Based on the changelog, apart from bug fixes, the main feature here is the CAE one. Are we 100% sure that the CAE feature is ready to go GA?
@jeremymeng, @sadasant, @xirzec

@xirzec
Copy link
Member

xirzec commented Jun 2, 2021

Based on the changelog, apart from bug fixes, the main feature here is the CAE one. Are we 100% sure that the CAE feature is ready to go GA?

I think my bigger concern is "how confident are we that the API surface for CAE won't need to change?" -- we can handle implementation bugs far more easily than needing to redact surface area.

@sadasant
Copy link
Contributor Author

sadasant commented Jun 2, 2021

@xirzec @jeremymeng, I’ll reach out to you both. I need some help understanding what is the correct path forward in this case. We’ve had so many meetings around this - I’m a bit lost of what applies and what doesn’t apply for us or what we may be missing. I’m sure I’ll be able to catch up once we sync up.

ramya-rao-a
ramya-rao-a suggested changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding review of "Request changes" to block the merge until we have had the conversations around CAE APIs being ready for GA

@joheredi
Copy link
Member

joheredi commented Jun 2, 2021

Is there a way to see the APIExtractor delta between this and 1.0.3?

@sadasant
Copy link
Contributor Author

sadasant commented Jun 2, 2021

@joheredi Here’s the diff: https://apiview.dev/Assemblies/Review/56af028213fa4d999098b3ce4bd5c3a1?diffRevisionId=8bf95f9c11544582a21ef64e4d62c652&doc=False&diffOnly=False

@sadasant
Copy link
Contributor Author

sadasant commented Jun 2, 2021

I’ve made a new issue to move Key Vault to this new public API #15522

Key Vault will help us validate the public API.

I’ll close this for now.

@sadasant sadasant closed this Jun 2, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Sep 7, 2021
CodeGen from PR 15502 in Azure/azure-rest-api-specs
dcfe9e2 
ResourceHealth - Swagger - AVAILABILITYSTATUSES API - 2020-05-01 Stable & Preview API versions (Azure#15502)

* Add files via upload

Stable - 2020-05-01 API version AvailabilityStatusesAPI

* Add files via upload

Preview - 2020-05-01 API version AvailabilityStatusesAPI

* Update readme.md

fixing the readme file

* Update readme.md

adding stable 202-05-01 API version

* Update ResourceHealth.json

fixed the PR checks for ResourceHealth.json Stable 2020-05-01 API version

* Delete ResourceHealth.json.bak

deleting .bak file

* Update ResourceHealth.json

fixed preview resourcehealth.json

* Update ResourceHealth.json

fixing the typo occurredTime

* Update ResourceHealth.json

fixing typo occurredTime

* Update ResourceHealth.json

fix PR errors

* Update ResourceHealth.json

fix PR checks

* Update ResourceHealth.json

fixing semantic validation

* Update ResourceHealth.json

fixing semantic validation for stable 2020-05-01 API

* Update custom-words.txt

fixing Swagger SpellCheck failure

* Update ResourceHealth.json

fixed Swagger PrettierCheck changes

* Update ResourceHealth.json

fixed Swagger PrettierCheck failure

* Update ResourceHealth.json

fixed Swagger LintDiff

* Update ResourceHealth.json

fixing Swagger LintDiff

* Update ResourceHealth.json

fix Swagger LintDiff failures

* Update readme.md

fixing swagger checks

* Update ResourceHealth.json

fixed eventid issue

* Update ResourceHealth.json

fixed eventId param

* Update ResourceHealth.json

fixing the Swagger PrettierCheck

* Update ResourceHealth.json

correcting the REsourceHealth.json file

* Add files via upload

uplaoding local files

* Add files via upload

fix swagger prettier

* Add files via upload

fix swagger pretttier issue - preview examples

* Add files via upload

fix prettier changes

* Add files via upload

fix swagger prettier changes

* Update readme.md

fixing Swagger Avocado failures

* Update ResourceHealth.json

fixing the ErrorResponse obj

* Update ResourceHealth.json

fix ErrorResponse

* Update ResourceHealth.json

adding operations API

* Update ResourceHealth.json

adding operations API

* Update ResourceHealth.json

removing EventIdParameter

* Update readme.md

fix .md file issue

* Update ResourceHealth.json

added operationsList

* Update ResourceHealth.json

added operationsList

* Add files via upload

fixing swagger prettier checks

* Add files via upload

fixing swagger prettier checks

* Update ResourceHealth.json

fixing semantic validation

* Update ResourceHealth.json

fixing semantic validation

* Create ResourceHealth.json

fixing the preview folder name

* Delete specification/resourcehealth/resource-manager/Microsoft.ResourceHealth/preview/2020-05-01-preview directory

delete temp

* Rename specification/resourcehealth/resource-manager/Microsoft.ResourceHealth/preview/2020-05-01/ResourceHealth.json to specification/resourcehealth/resource-manager/Microsoft.ResourceHealth/preview/2020-05-01-preview/ResourceHealth.json

renaming the folder name

* Rename specification/resourcehealth/resource-manager/Microsoft.ResourceHealth/preview/2020-05-01/examples/AvailabilityStatus_GetByResource.json to specification/resourcehealth/resource-manager/Microsoft.ResourceHealth/preview/2020-05-01-preview/examples/AvailabilityStatus_GetByResource.json

rename

* Rename specification/resourcehealth/resource-manager/Microsoft.ResourceHealth/preview/2020-05-01/examples/AvailabilityStatuses_List.json to specification/resourcehealth/resource-manager/Microsoft.ResourceHealth/preview/2020-05-01-preview/examples/AvailabilityStatuses_List.json

rename

* Rename specification/resourcehealth/resource-manager/Microsoft.ResourceHealth/preview/2020-05-01/examples/AvailabilityStatuses_ListByResourceGroup.json to specification/resourcehealth/resource-manager/Microsoft.ResourceHealth/preview/2020-05-01-preview/examples/AvailabilityStatuses_ListByResourceGroup.json

rename

* Rename specification/resourcehealth/resource-manager/Microsoft.ResourceHealth/preview/2020-05-01/examples/AvailabilityStatuses_ListBySubscriptionId.json to specification/resourcehealth/resource-manager/Microsoft.ResourceHealth/preview/2020-05-01-preview/examples/AvailabilityStatuses_ListBySubscriptionId.json

rename

* Update readme.md

fixing 2020-05-01-preivew paths

* Update custom-words.txt

reverting back  occured typo

* Update AvailabilityStatus_GetByResource.json

fix typo

* Update AvailabilityStatuses_List.json

fix typo

* Update AvailabilityStatuses_ListByResourceGroup.json

fix typo

* Update AvailabilityStatuses_ListBySubscriptionId.json

fix typo

* Update AvailabilityStatus_GetByResource.json

fix typo

* Update AvailabilityStatus_GetByResource.json

fix typo

* Update AvailabilityStatuses_List.json

fix typo

* Update AvailabilityStatuses_ListByResourceGroup.json

fix typo

* Update AvailabilityStatuses_ListBySubscriptionId.json

fix typo

* Update ResourceHealth.json

fix typo

* Update ResourceHealth.json

fix typo

* Update AvailabilityStatuses_ListByResourceGroup.json

fix typo

* Update AvailabilityStatuses_List.json

fix typo

* Update AvailabilityStatuses_ListBySubscriptionId.json

fix typo

* Update AvailabilityStatuses_List.json

fixed typo

* Update AvailabilityStatuses_ListByResourceGroup.json

fix typo

* Update AvailabilityStatuses_ListBySubscriptionId.json

fixed typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramya-rao-a ramya-rao-a ramya-rao-a requested changes

@ellismg ellismg ellismg approved these changes

@deyaaeldeen deyaaeldeen deyaaeldeen approved these changes

@jeremymeng jeremymeng Awaiting requested review from jeremymeng

@bterlson bterlson Awaiting requested review from bterlson

@chradek chradek Awaiting requested review from chradek

@xirzec xirzec Awaiting requested review from xirzec

@EmmaZhu EmmaZhu Awaiting requested review from EmmaZhu

@HarshaNalluru HarshaNalluru Awaiting requested review from HarshaNalluru

@jiacfan jiacfan Awaiting requested review from jiacfan

@joheredi joheredi Awaiting requested review from joheredi

@ljian3377 ljian3377 Awaiting requested review from ljian3377

@mikeharder mikeharder Awaiting requested review from mikeharder

@praveenkuttappan praveenkuttappan Awaiting requested review from praveenkuttappan

@southpolesteve southpolesteve Awaiting requested review from southpolesteve

@vinjiang vinjiang Awaiting requested review from vinjiang

@witemple-msft witemple-msft Awaiting requested review from witemple-msft

@XiaoningLiu XiaoningLiu Awaiting requested review from XiaoningLiu

@zfoster zfoster Awaiting requested review from zfoster

Assignees

@sadasant sadasant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sadasant @ramya-rao-a @xirzec @joheredi @deyaaeldeen @ellismg