Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MetricsAdvisor] Generated code and latest swagger #15748

Merged
merged 31 commits into from
Jun 24, 2021
Merged

[MetricsAdvisor] Generated code and latest swagger #15748

merged 31 commits into from
Jun 24, 2021

Conversation

KarishmaGhiya
Copy link
Member

@KarishmaGhiya KarishmaGhiya commented Jun 15, 2021 •
edited
Loading

  • Removed granularity type "PerSecond"
  • Made the parameters containing sensitive data in datasource credential types as optional
  • Returning the objects as part of update method response
  • Rename "createFeedback" to "addFeedback"
  • getmetricenrichedseriesdata and getmetricseriesdata seriesToFilter parameter renamed to seriesKey and ordering updated
  • updated tests and samples to reflect above
  • rename type "DetectionConditionsOperator" to "DetectionConditionOperator"
  • Rename property "splitAlertByDimension" to "dimensionsToSplitAlert" in AnomalyAlertConfiguration
  • Resolve eslint error
  • Rename "datasource" to "DataSource"
  • Renamed DatasourceCredential to DataSourceCredentialEntity, SqlServerConnectionStringDataSourceCredential to DataSourceSqlConnectionString,
    DataLakeGen2SharedKeyDataSourceCredential to DataSourceDataLakeGen2SharedKey,
    ServicePrincipalDataSourceCredential to DataSourceServicePrincipal,
    ServicePrincipalInKeyVaultDataSourceCredential to DataSourceServicePrincipalInKeyVault
  • listIncidents() overloads split into listInclidentsForAlert() and listIncidentsForDetectionConfiguration()
  • listAnomalies() overloads split into listAnomaliesForAlert() and listAnomaliesForDetectionConfiguration()

jeremymeng
jeremymeng reviewed Jun 18, 2021
View reviewed changes
Copy link
Member

@jeremymeng jeremymeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One rename suggestion

@jeremymeng jeremymeng changed the title Generated code and latest swagger [MetricsAdvisor] Generated code and latest swagger Jun 18, 2021
@jeremymeng
Rename
7bfe89a 
- MetricSeriesGroupDetectionCondition property `group` to `groupKey`
- MetricSingleSeriesDetectionCondition property `series` to `seriesKey`
@jeremymeng
publish updated samples
68fcd93
@jeremymeng
Rename
ce0aab4 
- `ListAnomaliesForAlertConfigurationOptions` property `dimensionFilter` to
`seriesGroupKeys`
- `ListFeedbackOptions` property `dimensionFilter` to `seriesKey`
- `ListIncidentsForDetectionConfigurationOptions` property `dimensionFilter` to
`seriesGroupKeys`
- `MetricEnrichedSeriesData` property `series` to `seriesKey`
- `MetricSeriesDefinition` property `dimension` to `seriesKey`
@jeremymeng
Rename
bded2a6 
- `MetricAnomalyAlertScope` property `dimensionAnomalyScope` to
`seriesGroupInScope`
@jeremymeng
Rename
325eff2 
- type `GetAnomalyAlertConfigurationResponse` to `GetAlertConfigResponse`
@jeremymeng
Fix readme code
59f65a3
@jeremymeng
Rename DataFeed to MetricsAdvisorDataFeed
68fd4c7
@KarishmaGhiya KarishmaGhiya merged commit 8afa5cf into Azure:main Jun 24, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Aug 24, 2021
CodeGen from PR 15748 in Azure/azure-rest-api-specs
ece26b8 
add config for sdk automation of newest rp (Azure#15748)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Aug 24, 2021
CodeGen from PR 15748 in Azure/azure-rest-api-specs
523bb30 
add config for sdk automation of newest rp (Azure#15748)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Aug 24, 2021
CodeGen from PR 15748 in Azure/azure-rest-api-specs
73f0f5a 
add config for sdk automation of newest rp (Azure#15748)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Aug 24, 2021
CodeGen from PR 15748 in Azure/azure-rest-api-specs
9a8556c 
add config for sdk automation of newest rp (Azure#15748)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Aug 24, 2021
CodeGen from PR 15748 in Azure/azure-rest-api-specs
616f4f1 
add config for sdk automation of newest rp (Azure#15748)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Aug 24, 2021
CodeGen from PR 15748 in Azure/azure-rest-api-specs
82c1a04 
add config for sdk automation of newest rp (Azure#15748)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Aug 24, 2021
CodeGen from PR 15748 in Azure/azure-rest-api-specs
cc24d82 
add config for sdk automation of newest rp (Azure#15748)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Aug 24, 2021
CodeGen from PR 15748 in Azure/azure-rest-api-specs
cd96ee8 
add config for sdk automation of newest rp (Azure#15748)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Aug 24, 2021
CodeGen from PR 15748 in Azure/azure-rest-api-specs
12fedf8 
add config for sdk automation of newest rp (Azure#15748)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Aug 24, 2021
CodeGen from PR 15748 in Azure/azure-rest-api-specs
f0922bd 
add config for sdk automation of newest rp (Azure#15748)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremymeng jeremymeng jeremymeng approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@chradek chradek Awaiting requested review from chradek

@xirzec xirzec Awaiting requested review from xirzec

Assignees
No one assigned
Labels
Cognitive - Metrics Advisor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KarishmaGhiya @jeremymeng