[KeyVault] - Add support for getRandomBytes operation #15955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
maorleger
commented
Jun 24, 2021
| @@ -19,12 +19,13 @@ | |||
| } | |||
| }, | |||
| "TestType": "node", | |||
| "NodeTestVersion": "10.x", | |||
| "ServiceVersion": ["7.0", "7.1"] | |||
| "NodeTestVersion": "14.x", | |||
There was a problem hiding this comment.
Now that 7.3-preview is the latest, we need an entry for 7.2 as well
maorleger
commented
Jun 24, 2021
maorleger
requested review from
bterlson,
chradek,
sadasant and
xirzec
as code owners
maorleger
commented
Jun 24, 2021
| @@ -327,7 +332,7 @@ export const enum KnownKeyCurveNames { | |||
| } | |||
|
|
|||
| // @public | |||
| export const enum KnownKeyOperations { | |||
| export enum KnownKeyOperations { | |||
There was a problem hiding this comment.
We should avoid const enum whenever possible, not breaking as the net-effect is the same for TS and additive for JS. I plan to incrementally replace const enum with enum where I can. I did not have lot of success with preserveConstEnums though
heaths
approved these changes
Jun 24, 2021
sadasant
reviewed
Jun 25, 2021
| @@ -49,5 +50,26 @@ onVersions({ minVer: "7.2" }).describe( | |||
| assert.equal(result.keyType, "oct-HSM"); | |||
| await testClient.flushKey(keyName); | |||
| }); | |||
|
|
|||
| onVersions({ minVer: "7.3-preview" }).describe("getRandomBytes", () => { | |||
sadasant
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
getRandomBytesmethodWhy