-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update pipeline to releae/track1 #15993
Conversation
@praveenkuttappan Please review |
eng/pipelines/mgmt-ci.yml
Outdated
@@ -1,7 +1,7 @@ | |||
trigger: | |||
branches: | |||
include: | |||
- main | |||
- feature/v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we just use our common pattern for both of these ci.yml files:
- main
- feature/*
- release/*
- hotfix/*
That way this pipeline will trigger for any branch follow the given pattern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/core/ci.yml#L21-L24 as an example of the common pattern in the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you ever plan to fork off a hotfix or release branch it might still be worth having those branch names as triggers. However we can add those later as needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that you will need to also update the pipelines in devops to point the default branch or any scheduled triggers to use feature/v4 as the branch instead of main.
Just as an FYI I checked and there are now ci or scheduled triggers for these pipeline so I think you are good. |
In the period of track2 sdk preview, we are going to use branch
feature/v4
to continue the release of track1 sdk.Besides this PR, I will also change the the release pipeline to trigger in branch
feature/v4