Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update engines, @types/node to Node.js v12, add changelog entry #15996

Merged
merged 8 commits into from
Jun 28, 2021

Conversation

ramya-rao-a
Copy link
Contributor

@ramya-rao-a ramya-rao-a commented Jun 25, 2021

This PR is the last leg of the work being done as part of #7022

Net changes:

  • package.json file
    • Update engines field to >=12
    • Update @types/node to `^12.0.0
    • Increment minor version if the package has gone GA before
  • linter
    • Update the eslint rule around the engines field to check for 12 instead of 8
    • Remove the turning off of the above eslint rule where people could not support Node.js 8
  • Add changelog entry if the package has gone GA before.
    • I used the "features" section as am treating the use of "new types" as a feature.

Other related work we already merged:

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run js - [service] - ci

Copy link
Member

@deyaaeldeen deyaaeldeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TA is looking good!

Copy link
Member

@xirzec xirzec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! What an incredible effort. Thank you for your diligence!

I will admit it feels a little bit odd to place the release note under 'features added', but I'm not sure where else it would go.

Copy link
Member

@ellismg ellismg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EventGrid changes look great, thanks for doing this, Ramya!

@@ -22,7 +22,7 @@
"module": "dist-esm/src/index.js",
"types": "./typings/event-processor-host.d.ts",
"engines": {
"node": ">=8.0.0"
"node": ">=12.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No version bump for this legacy package?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, no plans on releasing anything here.

Copy link
Member

@richardpark-msft richardpark-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

service-bus, event-hubs and monitor-query look good! This is awesome!

Copy link
Contributor

@chradek chradek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I was worried about the engines-strict setting but it is set to false by default and otherwise is just advisory, so it seems worth the push.

@ramya-rao-a ramya-rao-a merged commit 5a7c129 into Azure:main Jun 28, 2021
@ramya-rao-a ramya-rao-a deleted the node branch June 28, 2021 22:54
@ramya-rao-a ramya-rao-a changed the title Update engines, @types/node to Node.js v12 Update engines, @types/node to Node.js v12, add changelog entry Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants