[digital-twins-core] rename test folder and enable minmax testing #16049
Conversation
ghost
added
the
| @@ -7,6 +7,7 @@ stages: | |||
| ServiceDirectory: digitaltwins | |||
| MatrixFilters: | |||
| - TestType=^(?!sample).* | |||
There was a problem hiding this comment.
This is an old way of configuring min max testing that won't work anymore. Min/max is enabled by default now in the platform matrix: https://github.com/Azure/azure-sdk-for-js/blob/main/eng/pipelines/templates/stages/platform-matrix.json#L58
There was a problem hiding this comment.
Would reverting back to what it was by removing the TestMinMax: true line be sufficient here? Or does something else need to be done?
There was a problem hiding this comment.
Yep, just undo the change and it should work as intended. Let me know if you see different behavior than expected. You should see two test jobs like:
There was a problem hiding this comment.
Unfortunately, I don't see those jobs after removing the line tests.yml. @benbp
There was a problem hiding this comment.
You may have been looking at the CI tests, not the live tests? I kicked off a live test run, which should have them.
There was a problem hiding this comment.
Yep, that's what it was. Thanks!
|
/azp run js - digital-twins-core - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hello @vishnureddy17! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
close #13814