-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making secrets non-required, adding ref-docs #16087
Conversation
So, you explained to me offline that the sensitive fields are optional because the same interfaces are used both as input and output to/from the service, and the service will never fill in those fields. @xirzec had commented on the API view that a better experience would be to keep the sensitive fields as required when sending them to the service, but omit them entirely from the output interface. I do agree that this would be an improvement over making the fields always be optional. It would make sense for these fields to be optional if they were part of a patch operation, but that doesn't appear to be the case here. Separately, it looks like some tests may need to be re-recorded for the CI to pass. |
|
||
### Breaking Changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably worth a note that the library is also now GA 😄
Making secrets non-required, adding ref-docs:
Others: