Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sdk-type for core-client-paging #16176

Merged
merged 3 commits into from
Jul 2, 2021
Merged

Update sdk-type for core-client-paging #16176

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5211259
Update sdk-type for core-client-paging
praveenkuttappan Jul 2, 2021
25ebec3
Added path filter to ensure only copying one artifact per package
praveenkuttappan Jul 2, 2021
7266ee5
Added path filter to ensure only copying one artifact per package
praveenkuttappan Jul 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/core/core-client-paging-rest/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "@azure-rest/core-client-paging",
"version": "1.0.0-beta.1",
"description": "A helper library which implements Autorest x-ms-pageable spec for pagination.",
"sdk-type": "core",
"sdk-type": "client",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the correct sdk-type? I thought we were planning to create a new "rest" sdk-type for these LLC libraries.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joheredi is that something that is still on your list?

"main": "dist/index.js",
"module": "dist-esm/src/index.js",
"types": "types/latest/core-client-paging-rest.d.ts",
Expand Down