Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MetricsAdvisor] Fix readme data feed creation example #16223

Merged
merged 2 commits into from
Jul 6, 2021
Merged

[MetricsAdvisor] Fix readme data feed creation example #16223

merged 2 commits into from
Jul 6, 2021

Conversation

jeremymeng
Copy link
Member

The dataSourceParameter property has been flattened in latest Api.

Fixes #16105

@jeremymeng
[MetricsAdvisor] Fix readme data feed creation example
47afa96 
The `dataSourceParameter` property has been flattened in latest Api.
@jeremymeng jeremymeng requested a review from KarishmaGhiya as a code owner July 6, 2021 16:58
deyaaeldeen
deyaaeldeen approved these changes Jul 6, 2021
View reviewed changes
Copy link
Member

@deyaaeldeen deyaaeldeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the sample change is to make it match the public API

@jeremymeng
Copy link
Member Author

I assume the sample change is to make it match the public API

Yes that's right.

@jeremymeng jeremymeng merged commit 94e9190 into Azure:main Jul 6, 2021
@jeremymeng jeremymeng deleted the ma-fix-readme-example branch July 6, 2021 17:35
@jeremymeng jeremymeng mentioned this pull request Jul 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deyaaeldeen deyaaeldeen deyaaeldeen approved these changes

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya KarishmaGhiya is a code owner

Assignees
No one assigned
Labels
Cognitive - Metrics Advisor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Azure Metrics Advisor Readme And Sample Issue
2 participants
@jeremymeng @deyaaeldeen