[Identity] Add new StaticTokenCredential #16687
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Closed
7 tasks
sadasant
force-pushed
the
identity/fix15803-StaticTokenCredential
branch
from
18fcee5
to
1cfb8ca
Compare
|
This feature is not required in JS. const client = new SecretClient(vaultURI, { getToken: async () => accessToken }); |
I love this. Can we just show this as a sample? |
ghost
pushed a commit
that referenced
this pull request
Sep 1, 2021
This PR comes after the feedback here: #16687 Since there’s a very simple way to satisfy the `TokenCredential` interface, we can help users who want to provide their custom credentials by pointing them to this approach through our docs. Here’s an idea of how we can phrase these docs :) Feedback appreciated 👍
zihzhan-msft
added a commit
to zihzhan-msft/azure-sdk-for-js
that referenced
this pull request
Sep 22, 2021
commit 4271d639498a18c44c35b54817376919864f5c37
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Tue Sep 21 19:58:15 2021 -0700
Clean-up changelog scripts (#17774)
Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
commit 075e47e82d48678c999f514c186e590b7031228b
Author: ckairen <38804567+ckairen@users.noreply.github.com>
Date: Tue Sep 21 16:31:16 2021 -0700
Accounting for packages without samples (#17765)
commit f1a58bf9ec79b79db8a0c0e1fcf563cb40722711
Author: Malcolm Tyrrell <36992510+MalcolmTyrrell@users.noreply.github.com>
Date: Tue Sep 21 19:45:26 2021 +0100
Prepare for an initial release of Azure Remote Rendering beta package (#17747)
We haven't push an initial package for JS until now. We were waiting to push it at the same time as Python, but that has been delayed yet again, so let's just push this out, since we just pushed packages for Java and .net.
commit af6272333f4e9971269d10d72874d8f2b84dac02
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Tue Sep 21 11:20:32 2021 -0700
Automatic rush update --full (#17748)
commit c04c418184271bc8f5abcef33f6704a4b086f5af
Author: Hector Hernandez <39923391+hectorhdzg@users.noreply.github.com>
Date: Tue Sep 21 10:45:06 2021 -0700
Update OT Exporter to latest spec changes (#17752)
commit 3bde1f81943273d8e5851a64f6f535cf421b7ce9
Author: Wes Haggard <weshaggard@users.noreply.github.com>
Date: Tue Sep 21 08:39:45 2021 -0700
Enable release stage selection at queue time (#17758)
commit 9dc14fbd3f69e2f1fcef3bdb3eb6ad376a7862c6
Author: Maor Leger <maorleger@users.noreply.github.com>
Date: Tue Sep 21 07:34:57 2021 -0700
[KeyVault] - Retry flaky certificates test (#17757)
## What
- Automatically retry a certificate test that is known to be flaky up to 2 times (so 3 times total)
- Use the recorder.getUniqueName instead of the test name for the certificate name
## Why
- This test has been flaky for quite some time, and is known to fail when the service does not pick up the cancel operation job fast enough. This is both known and expected and the client should be resilient to such things. But in this case we are explicitly testing the error case and I did not want to remove that bit of safety
- Switching to using the recorder is IMO a preferred approach - and I have been doing that every time I re-record a test.
Resolves #17737
Resolves #17599
commit 0a7d6faba594e9719232a37d1fbb82ebb2edf152
Author: Scott Addie <10702007+scottaddie@users.noreply.github.com>
Date: Mon Sep 20 19:13:21 2021 -0500
Link to Log Analytics throttling guidance from Monitor Query README (#17754)
commit af1b6776b4feb40c15423c2692c900e4e0579559
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Mon Sep 20 17:07:33 2021 -0400
[Identity] Removing null from the AzurePowerShellCredential getToken (#17755)
commit b47c0dac14cd566964740f9bd7f927ad8b59af23
Author: Maor Leger <maorleger@users.noreply.github.com>
Date: Mon Sep 20 13:59:56 2021 -0700
[KeyVault] - Put Key Rotation back in for 7.3 (#17733)
After a few discussions we decided that Key Rotation is back in! So this commit reverts the revert and brings Key Rotation back.
commit 52e8d8196c1b2e44cd81c9abdbe8097001d77ef8
Author: Craig Treasure <Craig.K.Treasure@microsoft.com>
Date: Mon Sep 20 13:42:31 2021 -0700
Prepare Mixed Reality Authentication for initial beta release (#17753)
- This change prepares the Azure Mixed Reality Authentication package for an initial beta release.
commit d01edaf2f3c18901602b82a271d6c8db4e6ec8dd
Author: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
Date: Mon Sep 20 14:57:19 2021 -0500
Enforce https in bearerTokenPolicy (#17749)
commit e2f6e8d80101fdaa9c042d18b86838696c038ac6
Author: chradek <51000525+chradek@users.noreply.github.com>
Date: Mon Sep 20 09:38:16 2021 -0700
remove delay devDependency (#17305)
Resolves #17089
`@azure/abort-controller` doesn't use `delay` in any tests, so easy removal.
`@azure/service-bus` used `delay` for perf tests, but only as a promisified setTimeout. Removed dependency and replaced with a simple delay function.
commit 45de594e60f61d352d4467066a2c22223fdf6f98
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Sat Sep 18 16:36:39 2021 +0800
update-reade.md (#17744)
commit 6a350c64c8aaa74cc07e92f7d1f471736170e663
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Fri Sep 17 18:33:04 2021 -0400
[Schema Registry] Apply Archboard requested renames (#17720)
* [Schema Registry] Apply Archboard requested renames
* edit
* more renamings
commit 3a610f2b3c70912f7b51282f710dbcce3545e235
Author: KarishmaGhiya <kaghiya@microsoft.com>
Date: Fri Sep 17 14:29:50 2021 -0700
[monitor-query] fix what is publicly exported and make only one copy of function (#17562)
commit df4828a8152b75a96b6b6904d1aa925cd62f91b0
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Sep 17 10:20:55 2021 -0700
Sync eng/common directory with azure-sdk-tools for PR 2010 (#17718)
* Remove empty sections in changelog entry as part of prepare release
* Update SECTIONS_HEADER_REGEX to accomodate various header levels
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
commit bcb1827548713a4d239050257a3e1023af0e4474
Author: chradek <51000525+chradek@users.noreply.github.com>
Date: Fri Sep 17 10:07:16 2021 -0700
[event-hubs] Enable unit-test for node.js in CI (#17492)
Replaces #14568
Uses the `@azure/mock-hub` package to start a local mocked version of Event Hubs to run tests against.
There are a lot of whitespace changes (indentation) so I recommend viewing with whitespace changes hidden.
commit 2961b5ce3638249feed15b3404ca9057f789bdff
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Sep 16 22:33:56 2021 -0700
Post release automated changes for sql releases (#17725)
Post release automated changes for azure-arm-sql
commit 7351e8cf463dbe478b57c9a7fa385cf2a33cd358
Author: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com>
Date: Fri Sep 17 13:30:39 2021 +0800
Update automation_generate.sh (#17333)
* Update automation_generate.sh
* Update automation_generate.sh
commit 1e3c1e704b4e0b07164927e915c2a511cad6e703
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Fri Sep 17 09:56:32 2021 +0800
sql-track2 (#17724)
* sql-track2
* sql-track2
commit c3ef516578ee169ed8a1e34eb0089076f0224a6f
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Sep 16 16:03:19 2021 -0700
Post release automated changes for monitor releases (#17555)
Post release automated changes for azure-monitor-query
commit b413312412d7c5c0e522105740655285e9e76299
Author: Jeremy Meng <yumeng@microsoft.com>
Date: Thu Sep 16 15:39:15 2021 -0700
[credscan] unify passwords into a single place holder. (#17712)
commit 4b04f42bc12d449b36b827bc3887c0d901e6ab25
Author: Daniel Jurek <djurek@microsoft.com>
Date: Thu Sep 16 14:09:19 2021 -0700
Use default branch when queueing build in docindex (#16590)
* Add ability to override Docs CI source branch
* Wha thappens with an empty SourceBranch?
* Remove SourceBranch
* Comment out steps for faster iteration
* SourceBranch
* Readd skipped steps
* Remove extra added steps
commit 809f05c652ac9bb0fc08ce7048d8b5e33b9fc3e0
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Sep 16 12:33:45 2021 -0700
Sync eng/common directory with azure-sdk-tools for PR 2011 (#17698)
* Common pipeline template and script to detect API changes
* Cahnges as per review comments
* Review comment changes
* CCahgnes as per review comments
* Show warning for list of failed packages to detect API changes
* Apply suggestions from code review
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: praveenkuttappan <prmarott@microsoft.com>
Co-authored-by: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
commit 88ad5f17c8c8cdf68cb04713e92f5d4c7731a7a0
Author: CHILIU-MSFT <44037195+CHILIU-MSFT@users.noreply.github.com>
Date: Thu Sep 16 11:49:44 2021 -0700
Update signaling package version (#17716)
commit 27bb5a5a9b28ff30696bf86e78a4ebef24c12c9c
Author: Ramya Rao <ramya.rao.a@outlook.com>
Date: Thu Sep 16 11:22:58 2021 -0700
Remove references to specific Node.js versions in readmes (#17703)
Now that we have a support policy around Node.js versions, issues were logged as part of a sweep of all the documentation to ensure we don't mentioned specific Node.js versions and instead point to the support policy. This PR does the needful for a handful of packages. Similar changes are needed for some arm packages that will be managed by the mgmt plane team. Another issue for Track 1 cognitive services is #17603 which will be handled separately
Fixes #17632
Fixes #17650
Fixes #17663
Fixes #17668
Fixes #17678
commit cb58001106436ca62eeb8b95e92fcd2f7f0ebb2e
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Thu Sep 16 13:07:14 2021 -0400
[Schema Registry Avro] Move the shim file to types (#17704)
* [Schema Registry Avro] Move the shim file to types
* address feedback
commit 2c381b21ffc917bf22b4add10776278967ac85db
Author: Harsha Nalluru <sanallur@microsoft.com>
Date: Wed Sep 15 17:36:08 2021 -0700
[App Config] Add AZURE_AUTHORITY_HOST in the readme (#17711)
commit 004c36cbfb1a94e93db406b3bd7a53b7b556c1ac
Author: Jeremy Meng <yumeng@microsoft.com>
Date: Wed Sep 15 16:50:08 2021 -0700
[credscan] replace KV certificates in recordings with placeholder (#17593)
* [credscan] replace KV certificates in recordings with placeholder
Add a KV-certificate specific customization to replace base64-encoded
certificates in recordings with a placeholder. even though `"values":
"MII[^"]+"` looks very general, I checked all KV-certificates recordings and
found that all the occurrences are expected to be replaced.
Also fixed incorrect `dotenv` config in karma.config.js.
* Add KV certificate replacement placeholder to suppression list
* Skip playback test
commit 3a0dbd580ba69fe34a80cae9a49db0fbcc987121
Author: luc <44377201+LuChen-Microsoft@users.noreply.github.com>
Date: Wed Sep 15 15:56:26 2021 -0700
update communication signaling client (#17708)
commit 40ce26d0fcefc292e173920bec8c0504ee646984
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Sep 15 15:34:35 2021 -0700
Sync eng/common directory with azure-sdk-tools for PR 2016 (#17701)
* Make ServiceName optional for verify-changelog
In cases like go where we don't pass a service name having this default to "not-specified" breaks things so we should allow for ServiceName and/or ServiceDirectory to be empty.
* Put quotes around the strings to allow for empty
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
commit bb709c3c5275813b7f73ec729971151e5b35a1da
Author: Harsha Nalluru <sanallur@microsoft.com>
Date: Wed Sep 15 15:25:14 2021 -0700
[App Config] Fix live tests in UsGov and China clouds (#17583)
* prettier change
* yml file update
* Update the etst
* update test resources
* remove switch case
* adding some logs
* Updatre HMAC-SHA256 syntax to follow https://docs.microsoft.com/en-us/azure/azure-app-configuration/rest-api-authentication-hmac#syntax
* testApplicationOid
* testing with template fro .NET repo
* remove keyvault traces
* Add switch case statement to see if that matters
* update name
* add azure secrets as outputs
* update service version
* Update sdk/core/core-http/src/policies/deserializationPolicy.ts
* Update sdk/core/core-http/src/policies/deserializationPolicy.ts
* Update sdk/core/core-http/src/policies/deserializationPolicy.ts
* revert core-http
* Ben hates this snippet, let's remove and test
* changelog
* Update sdk/appconfiguration/app-configuration/CHANGELOG.md
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
commit 3c0e4cccf7b0061ecc6958cbe9639ef276566a96
Author: KarishmaGhiya <kaghiya@microsoft.com>
Date: Wed Sep 15 15:14:59 2021 -0700
open dependnecy update (#17709)
commit 03fd572ecdafaf72fe1e6081d6d0ea60c666dfa8
Author: KarishmaGhiya <kaghiya@microsoft.com>
Date: Wed Sep 15 13:36:39 2021 -0700
improvements (#17614)
commit 18f88f8cd9808a3a1c3e3648d9eaed57a528b8ac
Author: Hector Hernandez <39923391+hectorhdzg@users.noreply.github.com>
Date: Wed Sep 15 13:31:37 2021 -0700
[Azure Monitor Exporter] Fix issue with dependency type in DB Spans (#17705)
commit 178a0da0335b39d1bb4910508c3b165ee258af9f
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Sep 15 12:44:02 2021 -0700
Sync eng/common directory with azure-sdk-tools for PR 2009 (#17596)
* Skip PSModule caching in container jobs
* Add succeeded check to condition
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
commit 6cd128c09330c8787d1f9cbf987f0b17b2d828c2
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Wed Sep 15 15:08:56 2021 -0400
[Schema Registry] No longer return an undefined and throw instead (#17700)
commit 1a593e5b183daa62c94146c525306f8ea51446f5
Author: Jeremy Meng <yumeng@microsoft.com>
Date: Wed Sep 15 11:49:03 2021 -0700
Bump pnpm version to 6.14.2 (#17017)
pnpm 6.13.0 includes fix to the "tar" security vulnerability issue.
* pnpm v6 rename pnpmfile.js to .pnpmfile.cjs
See https://github.com/pnpm/pnpm/releases/tag/v6.0.0 for details.
* Add changes done by `rush update`
* rush update --recheck
* bump pnpm version to current latest version 6.14.2
* Adapt to pnpm change
to reduce directory nesting in virtual store, pnpm v6 replaces '/' in package
name with '+'.
https://github.com/pnpm/pnpm/pull/3117
https://github.com/pnpm/pnpm/pull/3314
This breaks `communication-chat` which has an
indirect dependency on earlier version of @opentelemetry/api that doesn't
provide `esm` support thus needs the commonjs plugin's named exports when
rolling up for browser.
* Fix native deps installation script
commit aced21f84bf4ac6c735b01a44e56022e096cc18e
Author: Jeremy Meng <yumeng@microsoft.com>
Date: Wed Sep 15 09:17:09 2021 -0700
[credscan] add placeholder for blob batch test secrets (#17609)
The affected tests are still skipped due to dynamic GUIDs in blob batch requests
but this PR does the work to replace shared keys with a place holder which is
suppressed in credscan.
* combine placeholder list
commit 265e233675ab188580a87ae1cf3f68bb722a9ba7
Author: Jeremy Meng <yumeng@microsoft.com>
Date: Tue Sep 14 17:49:24 2021 -0700
[credscan] add suppression placeholder for false positive (#17604)
* [credscan] add suppression placeholder for false positive
- api review file that happens to contain `export type Secret = Resource & {` https://github.com/Azure/azure-sdk-for-js/blob/de5a026e23211d1641d319dbd5d7a12710215953/sdk/keyvault/arm-keyvault/review/arm-keyvault.api.md#L1150
- a recording sanitization placeholder in ACR
commit 4868986e7f311d64478492c1571e59903ccbd3a1
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Tue Sep 14 20:14:08 2021 -0400
[Identity] Version changes after the releases (#17612)
New PR, smaller than the big one I made: https://github.com/Azure/azure-sdk-for-js/pull/17580
This PR:
- Changes the Identity package versions to the next beta (meaning, from 1.0.0-beta.2 to 1.0.0-beta.3 and to 2.0.0-beta.6 t o 2.0.0-beta.7).
- Sets some packages to use 2.0.0-beta.7 of Identity. Namely: The Identity package, the Key Vault packages and the Monitor Query (I’ve asked @maorleger and @KarishmaGhiya for permission 😄).
commit 903c9c244bee433912fad5a85aa172ba11443b42
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Tue Sep 14 16:56:17 2021 -0700
Add for multiple levels of Atx Headers in the CHANGELOG.md (#17613)
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
commit 4505aaee36a7df03bc04479647d43c3d9c55383b
Author: Jeremy Meng <yumeng@microsoft.com>
Date: Tue Sep 14 16:23:51 2021 -0700
[credscan] suppress fake test token communication-common README (#17594)
in file sdk/communication/communication-common/README.md
The decoded jwt token doesn't contain any secrets:
```js
{"header": {"alg":"HS256","typ":"JWT"}, "payload": {"exp":3600}}
```
I had considered using `"<user token>"` or similar in the README samples but
still prefer the fake test token as customer can understand easily what is
expected.
commit de5a026e23211d1641d319dbd5d7a12710215953
Author: Maor Leger <maorleger@users.noreply.github.com>
Date: Tue Sep 14 16:09:24 2021 -0700
[KeyVault] - Add provisioner OID to initial MHSM admins (#17611)
commit baf4ab0985b47d23c679d1ff408b7d8d98fd7d4f
Author: Maor Leger <maorleger@users.noreply.github.com>
Date: Tue Sep 14 12:50:53 2021 -0700
[KeyVault] - Add getCryptographyClient method to KeyClient (#17529)
## What
- Adds the `KeyClient#getCryptographyClient` convenience method
- Updates remoteCryptographyProvider to allow omitting the key version
## Why
A few reasons we're doing this:
1. Discoverability - by surfacing this at the top level it'll make `CryptographyClient` more discoverable
2. Being able to share an httpClient and Pipeline instead of continuously creating new ones
For the second bullet-point, I noticed in passing that we validate that the version exists and is not empty. That's incorrect, we
should allow version to be optional. The service supports it, all other languages do that, and our public API says version is
optional anyway.
Resolves #17529
commit 74f543c7768afd361881951053d1106219966f8b
Author: Jeremy Meng <yumeng@microsoft.com>
Date: Tue Sep 14 12:49:16 2021 -0700
[Engsys] Suppress credscan reported issues for test constants (#17505)
* Remove leftover recordings whose tests had been deleted
* Move test secrets into file so we can suppress the file, instead of suppressing using the unstable hashes
* Update suppression list
commit 12d4a7a129d9d0e63848ee64d536d7363f56172e
Author: Scott Addie <10702007+scottaddie@users.noreply.github.com>
Date: Tue Sep 14 13:34:04 2021 -0500
Final consistency review of Monitor Query README (#17591)
* Final consistency review of Monitor Query README
* Add rate limits section
commit 594ec5b29ccecf6c5df24af2121af93f8498e334
Author: luc <44377201+LuChen-Microsoft@users.noreply.github.com>
Date: Tue Sep 14 11:12:51 2021 -0700
Update communication signaling (#17605)
* update communication signaling
* update release date
commit c748074e97fa314f38ad4cf47ce6f8b0df996f0a
Author: Ramya Rao <ramya.rao.a@outlook.com>
Date: Tue Sep 14 10:10:14 2021 -0700
Update codeowners for communication packages (#17530)
commit 6845eb8dd3b1fc40ec4bea87c55cd734b815d47c
Author: Hector Hernandez <39923391+hectorhdzg@users.noreply.github.com>
Date: Tue Sep 14 09:02:14 2021 -0700
OpenTelemetry Exporter Fix issue loading SDK version (#17595)
commit 02bcfb182851c6b819dff4ac215318d8b27244e1
Author: Hirofumi Horikawa <hori.kawa.shima.tool+github@gmail.com>
Date: Tue Sep 14 10:25:31 2021 +0900
Loganalytics needs tokenAudience when creating creds (#15399)
commit a11723db439f975dd1049fc175f3d241e93af132
Author: Jeremy Meng <yumeng@microsoft.com>
Date: Mon Sep 13 16:38:15 2021 -0700
[core] fix incorrect caching of proxy agents (#17546)
The problem is that we only ever create one proxy agent and cache it, despite that different requests
could have different proxy settings. This PR fixes the issue by using a cache of a map of <string, AgentCache>,
with the string representation of proxy settings as the key.
Issue #16418
commit 0cc9db0c8de9df088d3c441b722152b38ae2cf9b
Author: Ramya Rao <ramya.rao.a@outlook.com>
Date: Mon Sep 13 15:23:24 2021 -0700
Set ensureConsistentVersions to false (#17587)
commit 2cecf7e7f7887b9df67b219896d37d3a0cb23af6
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Sep 13 13:50:41 2021 -0700
Sync eng/common directory with azure-sdk-tools for PR 1979 (#17589)
* Move logic for removing empty sections to ChangeLog-Operations.ps1
* Refactor sections regex
* Add SanitizeEntry parameter
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
commit 5e2a9429022ef28777791f89e91a5b91648caadf
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Sep 13 13:05:57 2021 -0700
Fix SemVer.ToString to handle v0 case (#17588)
Since we are treating v0 versions as prerelease we need to make sure
we don't accidently start to add the bogus prerelease label in cases where
we call ToString() on the version.
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
commit cc987d2b6f947740c6ce9502f730fd3c0ad5965e
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Sep 13 13:04:50 2021 -0700
Sync eng/common directory with azure-sdk-tools for PR 1946 (#17582)
* Add ability to exit gracefully when all files in the diff are excluded
* Address case where cspell exits with an error when all files from the 'files' config list are excluded by the expressions in 'ignorePaths'
* Add tests
* Review feedback: impl goes at the bottom and should be treated as a script, logic for testing should happen above that and exit appropriately if running tests
* Import common instead of logging
* Enable strict mode
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
commit 92de67e9dd49e7285899d41bbd1916cb4505707b
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Mon Sep 13 14:01:17 2021 -0400
[schema-registry-avro] serialize into JS's standard Uint8Array instead of Buffer (#17549)
* [schema-registry-avro] serialize into JS's standard Uint8Array instead of Buffer
* return a strict Uint8Array
commit 7d82d3331de2dbd8db193f49bb783ae60c4a4fb9
Author: KarishmaGhiya <kaghiya@microsoft.com>
Date: Mon Sep 13 09:28:03 2021 -0700
Monitor query test optimization (#17557)
commit 1852b2e6a6fef85e7ec0e6453d24603109d7f61b
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Sep 13 09:21:55 2021 -0700
Sync eng/common directory with azure-sdk-tools for PR 1983 (#17542)
* Doc Updates and Revisions for External Use
The focus of these changes is to revise the script to better support use
by external contributors and others outside of the Azure SDK ecosystem and
without access to the Microsoft AAD Tenant.
Changes include:
- Creation of a new Test Application service principal is now possible
from a non-Microsoft AAD tenant.
- When a new Test Application principal is created, the principle of least
privilege is now applied; the new Test Application is granted ownership
of the resource group associated with the test resources and no longer
has access to any other resources in the subscription.
- If an existing Test Application principal is specified, it will be
assigned ownership of the resource group created. This supports using
a Test Application principal without privileges at the subscription-level.
- When no provisioner is specified, the script is now executed in the
context of the caller rather than the Test Application principal.
This supports using a Test Application principal that has restricted
privileges and better aligns to the purpose of the Test Application
principal.
- The `$TestApplicationOid` is now explicitly bound at the time a new Test
Application principal is created rather than having to query for it later.
- Common error scenarios resulting from lack of permissions now provide
messaging with more context of why the failure occurred and suggest
remediation.
- Added new examples to illustrate the common call patterns needed by
external contributors running the script, outside of the Microsoft tenant
and Azure SDK ecosystem.
- Documentation has been enhanced with additional context to detail the
permissions and roles assigned by the script.
- Added documentation details for Bicep template use.
* Add the provisioner OID to the deployment params
Key Vault needs this to deploy Managed HSMs. There's a corresponding change necessary in test-resources.json I'll roll out across languages.
* Fixing typos and spelling mistakes
Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
Co-authored-by: Heath Stewart <heaths@microsoft.com>
commit 0f75384e3dd57dad670917da1d7ba95c8d740098
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Sep 13 09:18:41 2021 -0700
Automatic rush update --full (#17481)
commit 13861173b63f159ab71ae61f2c62da429ac69a6f
Author: Jeremy Meng <yumeng@microsoft.com>
Date: Fri Sep 10 15:38:24 2021 -0700
Upgrade dev dependency ts-node to ^10.0.0 (#17323)
commit b85b05a28f920558b5439d6f2ff95b35840db6b5
Author: ckairen <38804567+ckairen@users.noreply.github.com>
Date: Fri Sep 10 15:35:21 2021 -0700
Smoke test isolation per package (#17528)
* Smoke test isolation per package
* PR mod
* Error msg clarity
commit f34dcf0d719c58a1a9d701e8508708687120dc99
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Sep 10 13:52:58 2021 -0700
Post release automated changes for storage releases (#17567)
* Post release automated changes for azure-storage-blob
* Post release automated changes for azure-storage-file-share
* Post release automated changes for azure-storage-file-datalake
commit c48374bc6d24566991387f240271e8ffd5a1716b
Author: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
Date: Fri Sep 10 14:13:34 2021 -0500
[core-lro] Check for string type before calling toLowerCase() (#17573)
* Check for string type before calling toLowerCase()
* Update changelog
commit 45a3fd3dca4beea01de1fae766187fa2a4a9e612
Author: Ziheng Zhou(MSFT) <v-zihz@microsoft.com>
Date: Sat Sep 11 02:18:01 2021 +0800
Update search to enable live testing in sovereign clouds for multiple services (#17443)
* update to enable live testing in sovereign clouds for search
* Update search to enable live testing in sovereign clouds for multiple services
* update test-resources.json
* update recordedClient.ts
commit 59838aa40db22c0470f2a5e3119db8d452c247d7
Author: Harsha Nalluru <sanallur@microsoft.com>
Date: Fri Sep 10 10:34:29 2021 -0700
[Perf Tests] Migrate the older perf test projects to new model - event based SDKs (#17383)
* move to the new structure
* minor edits
* sample.env and readmes
* more changes
* track 2 service-bus looks fine
* track 1 also seems fine
* more fixes
* formatting
* Update sdk/eventhub/perf-tests/event-hubs-track-1/README.md
Co-authored-by: Daniel Rodríguez <sadasant@users.noreply.github.com>
* Update sdk/eventhub/perf-tests/event-hubs-track-1/README.md
* Apply suggestions from code review
* lock file
* lock file from master
* lock file
* all minor feedback
* more formatting
* remove prebuild
* more care for readmes
Co-authored-by: Daniel Rodríguez <sadasant@users.noreply.github.com>
commit 127625e3298cd3aba87437a6d44ffb00e1f558b5
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Sep 10 10:05:46 2021 -0700
Post release automated changes for synapse releases (#17508)
Post release automated changes for azure-synapse-managed-private-endpoints
commit 5b8efeea97ebd1fbaa25e68e9c50b077cc33bba3
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Sep 10 10:03:31 2021 -0700
Post release automated changes for purview releases (#17560)
Post release automated changes for azure-arm-purview
commit 9106fe32f5b2e306e6a853333d4d7b94862c7b97
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Sep 10 10:02:06 2021 -0700
Post release automated changes for storage releases (#17570)
Post release automated changes for azure-storage-queue
commit 2120d33a926269de3cb7a27bee91d86090bd95d9
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Fri Sep 10 11:58:15 2021 -0500
[Identity] Removed duplicated changelog line (#17572)
Woops! 😝 It went over our heads 😱
commit 45bc463e64b24e87a18ac58e4b85258b6e46be56
Author: EmmaZhu-MSFT <emmazhu@microsoft.com>
Date: Fri Sep 10 18:13:42 2021 +0800
Update changelog for storage-queue (#17569)
commit ac05634c654d51936ad57dd080bb45d3e9703f40
Author: Harsha Nalluru <sanallur@microsoft.com>
Date: Thu Sep 9 22:43:12 2021 -0700
Ignore formatting .env files (#17561)
Prettier tried to format my .env files by adding a `\` before a `.` present in a secret.
commit 1444b23aeb351e984f9d28585ca68aca453d33ab
Author: EmmaZhu-MSFT <emmazhu@microsoft.com>
Date: Fri Sep 10 13:39:34 2021 +0800
Upgrade storage packages versions. (#17564)
commit 1514d847f5a4fdb868d0407f40dcf308e5086f5a
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Thu Sep 9 19:13:09 2021 -0500
[Recorder v1] Fixed edge case double replacements (#17553)
I know this is an edge case, but it’s also a performance improvement 😄
Feedback appreciated!
Fixes #14353
commit 9efb573ecbd8df14bc9bfacb3bb1956211951afb
Author: KarishmaGhiya <kaghiya@microsoft.com>
Date: Thu Sep 9 16:51:09 2021 -0700
Monitor query updates (#17459)
commit b49ffb174f96dfa3fe019efae1a5c6ddfc98346e
Author: Hector Hernandez <39923391+hectorhdzg@users.noreply.github.com>
Date: Thu Sep 9 16:41:48 2021 -0700
Updating OT Exporter to align with latest mappings spec (#17392)
* Fix retry handling for Session Not Found errors
* Update sdk/cosmosdb/cosmos/test/internal/session.spec.ts
Co-authored-by: Zachary Foster <zfoster@users.noreply.github.com>
* Update CODEOWNERS for Application Insights (#17055)
* Updating Azure Monitor Exporter to align with latest schema spec
* Revert unwanted changes
* WIP
* Rush update
* Format
* Addressing comments
* Format
* Addressing comments
* Addressing comments
* rush update
* Do not throw when version cannot be loaded
* Fix test
Co-authored-by: Steve Faulkner <southpolesteve@gmail.com>
Co-authored-by: Zachary Foster <zfoster@users.noreply.github.com>
Co-authored-by: omziv <80668253+omziv@users.noreply.github.com>
Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com>
commit fd63748d34925b020151a823d2a599f56fb6e124
Author: Daniel Jurek <djurek@microsoft.com>
Date: Thu Sep 9 15:52:19 2021 -0700
Remove @azure/schema-registry-avro from docs onboarding until issue is addressed https://github.com/Azure/azure-sdk-for-js/issues/17550 (#17551)
commit d5a8e9bd68834003ef8fe660fcc49140a038418b
Author: Will Temple <witemple@microsoft.com>
Date: Thu Sep 9 17:48:04 2021 -0400
[identity] User study feedback and renames (#17466)
* Identity user study feedback changes.
* Apply suggestions from code review
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
* Added a couple more words to the error message for clarity
* prepare for release
* Format
* use javascript as the language specifier in sample code
* Fix browser mapping.
* Apply suggestions from code review
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
* fixed test
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
commit 4feb27b6de38e0f670e9b217e50fb35ebcee9a30
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Sep 9 14:01:17 2021 -0700
Install az module if not installed in deploy-stress-tests.ps1 (#17534)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
commit 5de257624fbe232d8039c9f720851af5a82c4572
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Sep 9 11:03:51 2021 -0700
Explicitly exit 0 so a failed inner command (like mvn) doesn't propagate up to a failure of the pipeline (#17537)
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
commit 838d804c19fb0d97ba17195a37957b9cbf37cfd3
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Sep 9 01:32:27 2021 -0700
Post release automated changes for servicebus releases (#17538)
Post release automated changes for azure-arm-servicebus
commit df6fef5611fd0d58445ec128002b18dd79ad5bc6
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Thu Sep 9 15:20:14 2021 +0800
servicebus-track2 (#17536)
* servicebus-track2
* update
commit c6c9c7de5bd2df85babb0ae8e9e04720d86dbf53
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Thu Sep 9 11:01:48 2021 +0800
purview-track2 (#17535)
* purview-track2
* update
commit 73942e3e81007d55521a248e64483e659f221770
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Sep 8 18:06:19 2021 -0700
Post release automated changes for azure-arm-network (#17515)
commit 160df574d4888091d4c2a8327474559e9a55c817
Author: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
Date: Wed Sep 8 19:48:09 2021 -0500
Add authorization header when allowInsecureConnection (#17517)
commit 0fd2d83d121a5df4c1587a48fad408501a995ecd
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Sep 8 17:28:15 2021 -0700
Sync eng/common directory with azure-sdk-tools repository (#17532)
commit 3cd09b44d516b27b0f1e56234f520f0417f881b4
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Wed Sep 8 19:25:39 2021 -0500
[Identity] 2.0.0-beta.6 release date (#17533)
We’ll be releasing Identity 2.0.0-beta.6 tomorrow 🎉
commit 35f3eddd60ef4df0189f1e1cce93dfd4f7b13bfe
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Wed Sep 8 18:39:08 2021 -0500
[Identity] Simple OnBehalfOfCredential (#17137)
* WIP
* added test file and another small test-related fix
* fixed test after things were up to date
* accepting certificate paths
* feedback from Jeff
* small improvements
* moved sendCertificateChain to the OnBehalfOfCredentialCertificateConfiguration
* inheritance improvements, by Jeff
* small fixes
commit 01e60581d456b22ab10100663e0a280f535f527e
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Sep 8 16:34:10 2021 -0700
Post release automated changes for azure-container-registry (#17531)
commit fb393b3e5def4dee817a11b391c67db899da17e4
Author: Daniel Jurek <djurek@microsoft.com>
Date: Wed Sep 8 14:58:21 2021 -0700
Readd batch to automated onboarding (#17525)
commit 85e5b46b39cfe5ce59a78de5ac399b8d9f514c20
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Sep 8 13:23:43 2021 -0700
Post release automated changes for keyvault releases (#17473)
Post release automated changes for azure-arm-keyvault
commit 9e79f881ac1c45c7aa2f466c000dba2adc9a6c6d
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Sep 8 13:00:38 2021 -0700
Add Skip.SetTestPipelineVersion to allow overidiing of use of BuildID for test version (#17519)
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
commit 6ccd67cb3d0fb8a26fd66d2f8de04f4705b773d7
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Wed Sep 8 12:25:56 2021 -0500
[Identity] Support exchanging k8s token to AAD token (#16688)
This is a simplified version of what @chlowell did on this PR: https://github.com/Azure/azure-sdk-for-python/pull/19902
This is based on what I understood. I’ll make sure to circle back with Charles before I get this PR out of draft.
Fixes #15800
commit 7156a37da9124a440e9198bdcadb835d4ebe7be9
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Sep 8 09:13:42 2021 -0700
Post release automated changes for azure-arm-locks (#17475)
commit 86c82c2702d01cfd29ad2c70476c318568fad058
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Sep 8 09:13:35 2021 -0700
Post release automated changes for azure-arm-links (#17474)
commit 71c39f954fd64fa8d41bdeea0ce26585538d39c1
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Sep 8 09:13:30 2021 -0700
Post release automated changes for azure-arm-policy (#17472)
commit 3c751edaf4a43fbbfaf165ac2824fd62055a73ee
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Sep 8 09:13:16 2021 -0700
Post release automated changes for azure-arm-resources (#17478)
commit 7162ba71713b76b8f6aa9792b9d1298445429138
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Sep 8 09:12:58 2021 -0700
Post release automated changes for azure-arm-managedapplications (#17476)
commit f33c5f21e0fab0ac80786ef27aaca7a5f141887d
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Sep 8 09:12:40 2021 -0700
Post release automated changes for azure-arm-sql (#17479)
commit f261ee15d42aa9e7a0ecc29c5f591dc143bae3e5
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Sep 8 09:12:25 2021 -0700
Post release automated changes for compute releases (#17396)
Post release automated changes for azure-arm-compute
commit 13a23801f54b657aeb06f334ea8fed27dc0c13e2
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Sep 8 09:12:19 2021 -0700
Post release automated changes for azure-arm-storage (#17480)
commit 65190ef9bcbe752eb3a17085956fa37aea56cd07
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Sep 8 09:12:11 2021 -0700
Post release automated changes for azure-arm-features (#17487)
commit b85a09baf749672ced1b22c8bddb2dac87857ba8
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Sep 8 09:08:23 2021 -0700
Post release automated changes for eventhub releases (#17488)
Post release automated changes for azure-arm-eventhub
commit 11cc2c5e114efdd67eec094f4d3c850334f3791f
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Wed Sep 8 17:33:49 2021 +0800
network-track2-release (#17507)
* network-track2-release
* update
commit 807736df4fee951f5370d1ea28d87cc75c6ec4af
Author: Jeremy Meng <yumeng@microsoft.com>
Date: Tue Sep 7 14:13:10 2021 -1000
[ContainerRegistry] prepare CHANGELOG for September release (#17498)
- update release date
commit 03474a234e175e4b7add14884a154e66bd4a9be6
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Tue Sep 7 16:10:19 2021 -0700
updating proxy to use latest version (#17501)
Co-authored-by: seankane-msft <seankane@microsoft.com>
commit 532247f8c1d094387c25868eaa254c03025a0b4d
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Tue Sep 7 19:02:38 2021 -0400
[schema-registry-avro] Clean up tests and dependencies (#17463)
* [schema-registry-avro] Clean up tests and dependencies
* restore testing against live resources
commit 1d460cc0b3f283460030bd9bf45db5ca56da9ab8
Author: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
Date: Tue Sep 7 12:47:19 2021 -0700
[Synapse] Re-generate Managed Private Endpoints (#17441)
Re-generate with swagger `2020-12-01`
commit caf46243c5544f67075401b709ef576041166597
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Tue Sep 7 13:36:18 2021 -0500
[Identity] Better DAC graph (#17491)
commit 710c7b3258cb2748ef44b0dc5aef636e8d10f1b2
Author: luc <44377201+LuChen-Microsoft@users.noreply.github.com>
Date: Tue Sep 7 10:40:00 2021 -0700
Update chat swagger (#17458)
* updated swagger
* update recordings
commit 18baa6991648c84249dea758cd84640041cefcd9
Author: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
Date: Tue Sep 7 10:36:26 2021 -0700
[Tables] Handle boolean when using `disableTypeConversion` and fix value type (#17385)
* Handle boolean and fix value type
* Update changelog
* Update recorded tests to include boolean properties
* Update recordings
* Address PR comments
commit a4eb25d8743912dc1688fac8ba83bf8e87c3ae44
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Tue Sep 7 14:20:11 2021 +0800
eventhub-track2 (#17486)
commit 3a21acf8265f5e090f017dfaf86e5d2d7faa598a
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Tue Sep 7 10:49:05 2021 +0800
features-readme-samples-update (#17485)
commit 81169fae68adb742143f6f0551b9f84195b8e067
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Mon Sep 6 15:46:13 2021 +0800
homepage-update (#17470)
* homepage-update
* update
commit 8a7f4e25fbbc25ea3ac1244ff1cf83326472f770
Author: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com>
Date: Fri Sep 3 15:28:58 2021 -0400
Skip updating samples if samples-dev is not present (#17454)
commit 1e0d4b5be16fdd1dbb5f8450cd0abaa182a7332d
Author: Sarangan Rajamanickam <sarajama@microsoft.com>
Date: Fri Sep 3 11:20:07 2021 -0700
Code Changes for Search-Documents SDK for September Release (V: 11.3.0-beta.3) (#17412)
* Beta 4 Changes
* Minor comment change
* Change to the odatatype
* Upated Recordings
* Update Changelog and Versions
commit 197e08da710542a928290e2acabfccd0c0f66782
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Fri Sep 3 13:57:09 2021 -0400
[Batch] fix npm packing (#17456)
* [Batch] fix npm packing
* bump version
commit b4907e28795e4616000f18e01d5985a19f444f8e
Author: codeorelse <siebe.hiemstra@greenhousegroup.com>
Date: Fri Sep 3 19:39:30 2021 +0200
Update README.md (#17450)
commit 8c282f5f638012c477fd3c9f9777076fd9f68dc9
Author: Maor Leger <maorleger@users.noreply.github.com>
Date: Fri Sep 3 08:24:04 2021 -0700
[core] - core-tracing compatibility matrix and README updates (#17346)
## What
- Update the core-tracing README's examples
- Add a Compatibility matrix section in core-tracing
- Add a troubleshooting section for Span#context -> Span#spanContext rename
## Why
- The samples are outdated as we no longer require `setTracer` to enable tracing and support automatic span propagation where possible
- We've been seeing more and more issues with compatibility between core-tracing, OpenTelemetry, and applicationinsights and it was suggested by one of our customers to add a compatibility matrix to aid in resolving such issues
- FInally, Span#context -> Span#spanContext rename was particularly painful as it's used in TracingPolicy - a perfect storm of changes put us in a position where this error might keep coming up.
I should note that even without any changes on our side, the above rename would cause errors for anyone who has pulled in OpenTelemetry >= 0.20 (including 1.0) as previous versions of core-http would still try to access Span#context (which has been renamed)
Partially resolves #16936
Resolves #17369
commit f0dca41fb833f66e324d7c388b0b5551fdad8e75
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Thu Sep 2 20:03:20 2021 -0400
[Schema Registry & Event Hubs] Upgrade api-extractor to v7.18 (#17440)
commit aaaefe54a845dcb9e87aa03ba26bd37171c8494d
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Thu Sep 2 19:31:47 2021 -0400
[Text Analytics] Upgrade api-extractor (#17428)
* [Text Analytocs] Upgrade api-extractor
* use latest
commit d5406a386146678a521803c4f7e497b0fd094487
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Thu Sep 2 17:48:25 2021 -0400
[Schema Registry] Rename getSchemaId to getSchemaProperties (#17438)
commit db4dfb21adc2d3712e294ec3c357aba70f34fc96
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Thu Sep 2 17:06:39 2021 -0400
[schema-regitry-avro] deserialize supports Blob (#17416)
* [schema-regitry-avro] deserialize supports Blob
* fix types path in the shim
* address feedback
commit 5a42da4806ea8072aed2a14f7500323a74871a73
Author: Ramya Rao <ramya.rao.a@outlook.com>
Date: Thu Sep 2 13:22:49 2021 -0700
Update code owners for cosmos (#17433)
commit eeb9fd63d9c0074d54819ca8b40f611049109275
Author: Maor Leger <maorleger@users.noreply.github.com>
Date: Thu Sep 2 12:30:55 2021 -0700
Increment version after release of core-http (#17430)
Unfortunately the [automation build](https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1077922&view=logs&j=e48a6a5a-3932-594b-dbbd-1adab0f233bc&t=3f58f8b2-03ca-5a9d-677f-c6fa3fac06c6)
failed due to an error in the Update samples step.
I manually ran the command `node ./eng/tools/versioning/increment.js --artifact-name azure-core-http --repo-root .`
commit 0977ab249a9dfd044c615fd7fdfa78534e6f2596
Author: Ramya Rao <ramya.rao.a@outlook.com>
Date: Thu Sep 2 12:24:02 2021 -0700
Remove unused dependency on proxy-agent (#17431)
commit e930d9c2a543861892b915135cf3df14427a29fe
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Sep 2 11:44:12 2021 -0700
Post release automated changes for authorization releases (#17395)
Post release automated changes for azure-arm-authorization
commit b97a2bf0c826a78800f06d54f9c194cdb4393409
Author: Scott Addie <10702007+scottaddie@users.noreply.github.com>
Date: Thu Sep 2 13:12:06 2021 -0500
Improve Monitor Query npm package description (#17399)
commit fdbd1038b2e3ce24c7e7aeebb07b121aeec9acae
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Sep 2 10:10:41 2021 -0700
Post release automated changes for azure-cosmos (#17427)
commit c1f540ce3fca9f8a54465f4fd511aff5a1e1d31c
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Sep 2 08:55:49 2021 -0700
Support v0 versions as prerelease beta versions (#17420)
Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
commit 0406e2e7dcd4e8ec220a1ccf4d386e52bb6a8be8
Author: Zachary Foster <zfoster@users.noreply.github.com>
Date: Thu Sep 2 10:30:44 2021 -0400
[Cosmos] Bump core-rest-pipeline version (#17426)
* cosmos should use 1.2.0
* Version bump to force installs
commit d5893c42fea5e1c5792b1ca5ee6ba13e336819dc
Author: KarishmaGhiya <kaghiya@microsoft.com>
Date: Wed Sep 1 18:16:05 2021 -0700
Ux study monitor (#16935)
commit b832d302a75a215771fa73ae3e0056b55084bb47
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Wed Sep 1 20:24:17 2021 -0400
[Identity] Update after Hotfix 1.5.2: Enabling insecure connection requests on the Arc MSI (#17394)
* [Identity] Update after Hotfix 1.5.2: Enabling insecure connection requests on the Arc MSI
* missing changelog entry in 2.0.0-beta.6
* Update sdk/identity/identity/CHANGELOG.md
Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com>
Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com>
commit b02bb87a33a60e9be06627eb875b33988764bb69
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Sep 1 17:12:58 2021 -0700
Make "Setup Versioning Properties" cancellable (#17418)
Co-authored-by: Mike Harder <mharder@microsoft.com>
commit c9545794238645b3f225ce1738043a2d6ad8b8e6
Author: Maor Leger <maorleger@users.noreply.github.com>
Date: Wed Sep 1 16:31:49 2021 -0700
[core] - fix core-http release date (#17417)
When I first ran the prepare-release script I didn't override the date. I ran it again providing a date but it did not update the
changelog for some reason. I later missed it in the PR.
So, updating the date to tomorrow!
commit 4fbd5ef5cd5bcc3688f7722449fb618dd3a160fd
Author: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
Date: Wed Sep 1 16:26:26 2021 -0700
[Rest clients] Explicitly set pipeline policies (#17015)
* Explicitly set pipeline policies
* Extract createPipelineFromOptions
* Update core-client versions
* Address PR comments
* Add missing license header
* Expect exponential retry policy
* moved pipeline options
* Update changelog
commit 90c6423dc5ac2af2a224db3a7cbb75a5c7a0f0b5
Author: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
Date: Wed Sep 1 15:44:29 2021 -0700
[core-rest-pipeline] Allow number and boolean as input headers (#17358)
* Allow number and boolean as input headers
* Address PR comments
* Address PR Comments
commit 855ff1819591eb67f0e4ba2c2896fd7826b1dcce
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Wed Sep 1 18:16:24 2021 -0400
upgrade buffer to v6 (#17414)
commit e332906c845259ac6d5a866f9ac37211ddf9c406
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Wed Sep 1 17:18:03 2021 -0400
[Identity] Simplest possible credential sample (#17411)
This PR comes after the feedback here: https://github.com/Azure/azure-sdk-for-js/pull/16687
Since there’s a very simple way to satisfy the `TokenCredential` interface, we can help users who want to provide their custom credentials by pointing them to this approach through our docs. Here’s an idea of how we can phrase these docs :)
Feedback appreciated 👍
commit fa72157bff5a5dd756ddc3020b24d8e8b1cb8aed
Author: Maor Leger <maorleger@users.noreply.github.com>
Date: Wed Sep 1 13:36:55 2021 -0700
[core] Prepare release for core-http and core-rest-pipeline (#17403)
commit 3591d5f045d18ce1ab43d1f20223b645a1a044aa
Author: Harsha Nalluru <sanallur@microsoft.com>
Date: Wed Sep 1 12:49:21 2021 -0700
[Recorder] Fix types in the published package (#17409)
* typings to types
* update version
commit 01ee023e503253dbcd7e82526dbe40ad487ceda9
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Sep 1 12:27:00 2021 -0700
Increment version for monitor releases (#16270)
Increment package version after release of azure-monitor-opentelemetry-exporter
commit a5a5795bb445f3a1eefa330ffbd6bdc150a79c79
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Sep 1 10:50:57 2021 -0700
Increment version for storage releases (#16630)
commit 5107d08c5021e03e334e40d1216eb16576a6a9f3
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Sep 1 10:49:40 2021 -0700
Increment package version after release of azure-communication-network-traversal (#16479)
Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com>
commit 073d5739ad69aace64eb798f96be7ba82ffcea6f
Author: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com>
Date: Wed Sep 1 13:30:29 2021 -0400
Fix Log error (#17382)
commit 6d9c588eb91c4c4d63fe5f05b0d00e610f06330a
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Sep 1 10:24:20 2021 -0700
Increment package version after release of azure-communication-common (#16522)
commit bdd46de978d1c2e0b7c599d9e043e069c8c7c1e5
Author: Maor Leger <maorleger@users.noreply.github.com>
Date: Wed Sep 1 10:22:13 2021 -0700
[sample] - remove unnecessary OTel exports in Bundling.md sample (#17400)
Resolves #7313
commit a3ca3b4c8e72c31b042ec8a0ea311f9001f0fcf6
Author: Maor Leger <maorleger@users.noreply.github.com>
Date: Wed Sep 1 09:55:52 2021 -0700
[KeyVault] - Prepare release for keyvault certificates and secrets September release (#17404)
commit 2f07b264551cd1c2882a66ea8dde2e16000a6488
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Sep 1 09:17:50 2021 -0700
Post release automated changes for cosmosdb releases (#17401)
Post release automated changes for azure-cosmos
commit 04ca8a122de179bf2ee58732e2149fc6d2f80ad9
Author: Zachary Foster <zfoster@users.noreply.github.com>
Date: Wed Sep 1 11:05:16 2021 -0400
[Cosmos] Adds challengeCallbacks to bearerTokenAuthPolicy (#17289)
* Adds challengeCallbacks to bearerTokenAuthPolicy
* Format
* 1.2.0
* Remove unused import
* Remove unused auth header in auth.ts and fix clientcontext token
* Adds changelog entry
* note Batch for patch operation since we note bulk
commit 0bb5958f8c76dc4746eda992d0c2046ada2bfa11
Author: OnO <i@mdzz.name>
Date: Wed Sep 1 08:39:34 2021 +0800
fix spelling error in AccountSASPermissions.ts (#15263)
commit 38c1b14b84df6cd820c86d55abe71d70fad95ba7
Author: Kevin <skiimilk@gmail.com>
Date: Wed Sep 1 02:35:41 2021 +0200
Fix spelling errors in ConnectionMode.ts (#15190)
commit bc68409220c72c8bc95c87e4c4a3360f77ebb165
Author: Maor Leger <maorleger@users.noreply.github.com>
Date: Tue Aug 31 17:24:16 2021 -0700
[KeyVault] - Regenerate secrets and certificates using 7.3-preview (#17389)
## What
- Regenerate certificates and secrets against the 7.3-preview swagger
- Update certificate and secrets package versions to beta of next minor
## Why
Although there are no changes in these packages, we should still offer support and default to the latest swagger version
which will be 7.3.
Since we'll be GAing in October, it makes sense to have a beta in September.
commit aeafc4b6e4697fa9720b3fb2734b9243f7beeeda
Author: Zachary Foster <zfoster@users.noreply.github.com>
Date: Tue Aug 31 19:01:02 2021 -0400
[Cosmos] Adds JSONPatch to item (#16264)
* working patch test
* Adds patch functionality
* Fix lint
* Fix lint and export warning
* remove unused dec
* Fix engine
* Remove partitionKeyValue from item
* fix replace copypasta
* Adds version
* Add patch to batch/bulk with tests and fix patch operation type
* .only
* Include missing types from index
* Fixes changelog
commit 00b46e74aacfb9c6131c8b9cba9b1366a28f253c
Author: Jiao Di (MSFT) <80496810+v-jiaodi@users.noreply.github.com>
Date: Wed Sep 1 06:05:52 2021 +0800
Fix Monitor Query Readme Issue (#17376)
commit 4e2876660795d3067ca8f943d0bc353b568e5314
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Tue Aug 31 16:41:08 2021 -0400
[Identity] Fixed silent requests after reusing persistence cache (#17324)
Updated `@azure/msal-node` and `@azure/msal-node-extensions`, which fixed an issue that caused silent authentication to fail on requests with previously cached (and valid) tokens.
Fixes #14701
Fixes #15833
commit b6eae92ed2e1c222fd0f692c5e7a34398115adcf
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Tue Aug 31 16:12:41 2021 -0400
[Identity] Updated the DefaultAzureCredential graph (#17304)
commit cf3c4b9cb70a8f35cd5f0e92aa11077d5d870b1e
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Tue Aug 31 15:51:55 2021 -0400
[Schema Registry] Trim down Schema Properties (#17360)
* [Schema Registry] Trim down Schema Properties
* update avro text
commit 1caf872697e6b6fb84da22a99b8d6433a144057a
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Tue Aug 31 15:04:59 2021 -0400
[Identity] Revert selected credential (#17322)
* Revert "[Identity] Exposing the selected credential on ChainedTokenCredential (#16683)"
This reverts commit 535e026e7aa605b1a76f2c10c9de89518d0a021e.
* changelog update
commit 4a6277fac05a60304c5eebf054e72ba23842d66d
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Tue Aug 31 11:59:47 2021 -0700
Post release automated changes for web-pubsub releases (#17374)
Post release automated changes for azure-arm-webpubsub
commit 648b2ebd99b96b7b448ddec1fe188f2e2389fa3a
Author: Jiao Di (MSFT) <80496810+v-jiaodi@users.noreply.github.com>
Date: Wed Sep 1 00:29:03 2021 +0800
Fix Event Grid Readme Issue (#17377)
commit d70ebc9b122b909c1f5847d3fd08705748bb7f85
Author: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com>
Date: Tue Aug 31 10:46:14 2021 -0400
Do not fail cleanup tags when a package is published for the first time (#17338)
commit 46ed1e76b2997ed9ef4975e90e8b48a034db350e
Author: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com>
Date: Tue Aug 31 10:44:43 2021 -0400
Remove rush update recheck automation (#17349)
commit 636659dcb188512e44cdb8747446b30d86471cdf
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Tue Aug 31 17:52:44 2021 +0800
authorization-track2 (#17380)
commit cfd3565fccca77df771bb3e538df6af2ee7c22be
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Tue Aug 31 17:52:35 2021 +0800
compute-tack2 (#17051)
* compute-tack2
* update
commit b0162164f1a1ff02a6cabe4af18dc1dc6b2259ae
Author: EmmaZhu-MSFT <emmazhu@microsoft.com>
Date: Tue Aug 31 13:09:53 2021 +0800
[storage]Clean up ESLint errors for storage packages. (#16969)
* Clean up ESLint errors for storage packages.
* Fix one more ESLint error.
* Resolve reviewing comments
* Remove padStart implementation for IE.
commit aaec5b9aa01e3d950c906100c962bad19d93e924
Author: EmmaZhu-MSFT <emmazhu@microsoft.com>
Date: Tue Aug 31 09:54:13 2021 +0800
Resolve API review comments: (#17118)
Not expose ListFilesIncludeType which is only internal used.
Refine member name
commit c4b6126b54b4aef385104b14164321050e60d569
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Aug 30 17:45:57 2021 -0700
Sync eng/common directory with azure-sdk-tools for PR 1953 (#17355)
* Add random elements to default base name
* Fix principal
* tab
Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
commit 9fcaef60d5d6f5a814a0155efc626106f4362198
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Aug 30 17:21:09 2021 -0700
Skip eng common workflow enforcer for private repos (#17351)
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
commit dafbac160816260d2287bd87ddb89138854b455e
Author: Scott Addie <10702007+scottaddie@users.noreply.github.com>
Date: Mon Aug 30 19:16:51 2021 -0500
Clarify LogsQueryClient query parameter description (#17356)
commit 5aeb275294a85602166bf2e5997452ae0398c065
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Mon Aug 30 19:48:26 2021 -0400
[Schema Registry Avro] Align public API (#17350)
* [Schema Registry Avro] Align public API
* update api review
commit 71ba6b085065eb75bb41d9983d995540181b9f9d
Author: KarishmaGhiya <kaghiya@microsoft.com>
Date: Mon Aug 30 13:53:59 2021 -0700
remove qs (#17328)
commit 6ff03729d1a1f234d9c7deeee28c03bbb9bcea99
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Mon Aug 30 15:38:56 2021 -0400
[core-paging] update changelog (#17340)
* [core-paging] update changelog
* fix files list
commit 0a917741ab1d8b6a585642f8089f344925c9e58a
Author: Ramya Rao <ramya.rao.a@outlook.com>
Date: Mon Aug 30 12:34:25 2021 -0700
Update version of execa being used (#17320)
This PR updates the version of `execa` being used
Fixes https://github.com/Azure/azure-sdk-for-js/issues/17093
The only breaking change of concern is listed https://github.com/sindresorhus/execa/releases/tag/v4.0.0 where it is documented that the `error.message` now contains more information. In this PR, we move to use `error.shortMessage` instead
commit dc6d4243ce4a3a66043ae39979fc047e940f833e
Author: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
Date: Mon Aug 30 11:11:52 2021 -0700
Bubble up system error code for the retry policy to evaluate the actual code (#17292)
commit 30d50cb50f9d353bfeb0ba3b299586e8c7b7c888
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Aug 30 11:07:54 2021 -0700
Automatic rush update --full (#17335)
commit 2e23b80604f856564b3b1d3821a03de07bc77788
Author: Maor Leger <maorleger@users.noreply.github.com>
Date: Mon Aug 30 09:06:58 2021 -0700
[core] - Ignore spanOptions in core-tracing tests (#17336)
We have a few tests that ensure core-tracing remains compatible with core-auth's OperationTracingOptions.
Since `spanOptions` is now effectively deprecated we can safely ignore that as well, but we need to specifically ignore
it in our test because of the versioning mismatch in nightly builds.
Fixes the nightly build (see https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1067749)
commit 900c09ea928787a368e8b4da35d9b9cc59be1491
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Aug 27 16:07:20 2021 -0700
Sync eng/common directory with azure-sdk-tools for PR 1943 (#17319)
* Bug fix: Storing .env file for bicep file at service dir
* Styling
Co-authored-by: Albert Cheng <albertcheng@microsoft.com>
commit 2074482b0f47de92b28b9935d00c9ea1d13701fd
Author: Jeremy Meng <yumeng@microsoft.com>
Date: Fri Aug 27 12:09:13 2021 -1000
Upgrade dev dependency @types/tunnel to ^0.0.3 (#17317)
It appears not used by cosmos so removing it from cosmos's devDependencies list.
Resolves #17111
commit 0c1a11da1f2a27c7aa45217933e4785ad85fd308
Author: Jeremy Meng <yumeng@microsoft.com>
Date: Fri Aug 27 11:35:02 2021 -1000
Upgrade `form-data` to v4 (#17318)
Even though it's a major version change, discussion at
https://github.com/form-data/form-data/compare/v3.0.1...v4.0.0
suggests that there are no actual breaking changes.
commit eeae1e5a6a01c58fd7403e413d6c2e0293256988
Author: Jeremy Meng <yumeng@microsoft.com>
Date: Fri Aug 27 11:33:58 2021 -1000
[ContainerRegistry] Update cloud configuration API (#16992)
We are moving from an `authenticationScope` string to an `audience`
extensible enum on `ContainerRegistryClientOptions`. We introduce the
`KnownContainerRegistryAudience` enum to hold the possible values, or
allow the customer to provide a different value if needed.
In addition, we require the `audience` value to be set in client
options to instantiate any instance of `ContainerRegistryClient`. This
allows us to postpone setting a default value for audience until after
the library's first GA.
See relevant .NET PR at
https://github.com/Azure/azure-sdk-for-net/pull/23141.
This resolves https://github.com/azure/azure-sdk-for-js/issues/16127.
commit 974a68525f01822a984a4cf1cedda009955bc8fa
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Aug 27 14:05:41 2021 -0700
Automatic rush update --recheck (#17117)
commit 4b84df04c686a4cb08fc24cc2e7a619fbfb601d5
Author: Harsha Nalluru <sanallur@microsoft.com>
Date: Fri Aug 27 13:25:42 2021 -0700
[Recorder] Releasing recorder to public - not setting private anymore (#17314)
commit f504378caa7a33f6366eb3365736a59ffb74d784
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Aug 27 11:25:23 2021 -0700
ensure test principal creation succeeds properly (#17312)
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
commit 0f7ccdb49ac51f6c1538f5e0b735f82c1674c6b6
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Fri Aug 27 13:30:26 2021 -0400
[Schema Registry] Cross-languages API alignment (#17291)
* [Schema Registry] Cross-languages API alignment
* format in the avro pkg
commit 17523f2288aab13eed1d503d8fd078e38a6145ac
Author: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com>
Date: Fri Aug 27 13:21:33 2021 -0400
Skip update samples post release script for track2 management packages (#17295)
commit c776973e578fa562421c4977c42a7d9fb9fa86ad
Author: Jeremy Meng <yumeng@microsoft.com>
Date: Fri Aug 27 06:27:07 2021 -1000
Fix codespace docker permission issue (#17306)
in `1-linux` we need `--privileged` in devcontainer's `runArgs`
commit 9b74007d1c48a0de5f05ed58dd5b4d85683bc3e0
Author: Ramya Rao <ramya.rao.a@outlook.com>
Date: Fri Aug 27 08:12:43 2021 -0700
Remove mock-fs, query-string, @types/query-string if they are…
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Nov 10, 2021
A new API version 2021-10-01 on MS.Subscription (Azure#16687) * Copied the last item from private repo and renamed to 2021-10-01 * Updated the version to 2021-10-01 * Error response is updated. It is required by OpenAPI Validation Tools(linter) * http status response on post method is updated to 201 from 202; required by OpenAPI Validation Tools(linter) * description is added in #definitions.Operation.properties.display; required by OpenAPI Validation Tools(linter) * updated error response to match it previous * systemData properties are added; required by Swagger validation on the PR * updated readme.md for the new version * removed a file getSubscriptionOperation.json as long as it is not referenced; required by Swagger Avocado on the PR * Modified style by npm prettier * executed npm run prettier; required by prettier check on PR * added type:object; required by swagger LintDiff * added type:object; required by swagger LintDiff * reverted back the post response of acceptOwnership to 202 * http status response on post method is updated to 201 from 202; required by OpenAPI Validation Tools(linter) * reverted back the post response of acceptOwnership to 202 Co-authored-by: Ochi <ochisamand@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How does this look?
Related to this prototype PR (but this one includes many more things): jongio/azidext#41
Related to #15803