Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homepage update #16719

Merged
merged 9 commits into from
Aug 4, 2021
Merged

homepage update #16719

merged 9 commits into from
Aug 4, 2021

Conversation

colawwj
Copy link
Contributor

@colawwj colawwj commented Aug 3, 2021

to fix issue #16718

@qiaozha qiaozha merged commit a716a21 into Azure:feature/v4 Aug 4, 2021
@weshaggard
Copy link
Member

@qiaozha are we sure we want this change? I ask because now even the newer track 2 versions of the package point to the feature/v4 branch. Take a look at https://www.npmjs.com/package/@azure/arm-compute/v/30.0.0-beta.1 for example. I suspect npm updates the website based on the latest published package and not necessarily based on a given version. So we might need to figure out a better strategy here.

@qiaozha
Copy link
Member

qiaozha commented Aug 5, 2021

@weshaggard I see the problem now. I thought npm could point to different homepage for different version. We made this change because we got our customer complain about our doc is outdated. but the root cause is that he was using track1 SDK and our homepage points to main branch. Then how are we going to make it work? Should we point all the homepages for RPs that have previewed track2 sdk to the main branch ?
@nickzhums @lirenhe What's your thoughts ?

@weshaggard
Copy link
Member

I'm not sure we have a great solution to this problem. Maybe our best option would be to keep the homepages pointing at main, at least for the track 2 versions and then maybe add a note in the README for those libraries that point to the feature/v4 branch for any of the older versions.

@ramya-rao-a
Copy link
Contributor

I agree with Wes.
Keep the main branch as homepage, update readme for Track 2 packages in preview saying that for older stable version, one can to the feature branch. When the Track 2 packages go GA, you can remove that note from the readme

@ramya-rao-a
Copy link
Contributor

Also, looks like @azure/graph package was included in this PR and it should not have been. It is not an ARM package

@praveenkuttappan
Copy link
Member

@qiaozha : We have noticed that @azure/graph 5.0.3 was unintentionally got released due to change in this PR to update version to 5.0.3.

Can we please ensure we don't update any of these track1 packages on feature/v4 branch. As an additional step, I am going to update gulp script on feature/v4 to skip all track1 packages so it get's released by new pipelines being created for track1 dataplane package only,.

@qiaozha
Copy link
Member

qiaozha commented Aug 6, 2021

@ramya-rao-a @pragyamehta sorry about that, we will keep an eye on data plane files in the future. @colawwj Please also pay attention to it. Thanks

@qiaozha
Copy link
Member

qiaozha commented Aug 6, 2021

I agree with Wes.
Keep the main branch as homepage, update readme for Track 2 packages in preview saying that for older stable version, one can to the feature branch. When the Track 2 packages go GA, you can remove that note from the readme

We will update the current previewed track2 packages readme.md later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants