-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
homepage update #16719
homepage update #16719
Conversation
@qiaozha are we sure we want this change? I ask because now even the newer track 2 versions of the package point to the feature/v4 branch. Take a look at https://www.npmjs.com/package/@azure/arm-compute/v/30.0.0-beta.1 for example. I suspect npm updates the website based on the latest published package and not necessarily based on a given version. So we might need to figure out a better strategy here. |
@weshaggard I see the problem now. I thought npm could point to different homepage for different version. We made this change because we got our customer complain about our doc is outdated. but the root cause is that he was using track1 SDK and our homepage points to main branch. Then how are we going to make it work? Should we point all the homepages for RPs that have previewed track2 sdk to the main branch ? |
I'm not sure we have a great solution to this problem. Maybe our best option would be to keep the homepages pointing at main, at least for the track 2 versions and then maybe add a note in the README for those libraries that point to the feature/v4 branch for any of the older versions. |
I agree with Wes. |
Also, looks like |
@qiaozha : We have noticed that @azure/graph 5.0.3 was unintentionally got released due to change in this PR to update version to 5.0.3. Can we please ensure we don't update any of these track1 packages on feature/v4 branch. As an additional step, I am going to update gulp script on feature/v4 to skip all track1 packages so it get's released by new pipelines being created for track1 dataplane package only,. |
@ramya-rao-a @pragyamehta sorry about that, we will keep an eye on data plane files in the future. @colawwj Please also pay attention to it. Thanks |
We will update the current previewed track2 packages readme.md later. |
to fix issue #16718