Monitor query align the request bodies #16760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarishmaGhiya
requested review from
maorleger and
richardpark-msft
as code owners
ghost
added
the
KarishmaGhiya
changed the title
maorleger
requested changes
Aug 4, 2021
| @@ -13,15 +13,12 @@ export type AggregationType = "None" | "Average" | "Count" | "Minimum" | "Maximu | |||
|
|
|||
| // @public | |||
| export interface BatchQuery { | |||
| azureResourceIds?: string[]; | |||
| additionalWorkspaces?: string[]; | |||
There was a problem hiding this comment.
additionalWorkspaceIds maybe? Unless this is how all languages called it
There was a problem hiding this comment.
Yes this is across all languages
| @@ -83,7 +80,7 @@ export type LogsColumnType = string; | |||
| // @public | |||
| export class LogsQueryClient { | |||
| constructor(tokenCredential: TokenCredential, options?: LogsQueryClientOptions); | |||
| queryLogs(workspaceId: string, query: string, timespan: string, options?: QueryLogsOptions): Promise<QueryLogsResult>; | |||
| queryLogs(workspaceId: string, query: string, timespan: string, additionalWorkspaces?: string[], options?: QueryLogsOptions): Promise<QueryLogsResult>; | |||
There was a problem hiding this comment.
I think additionalWorkspaces should be in the options bag - at least that's how I'm used to seeing additional optional params
| @@ -89,7 +91,8 @@ export class LogsQueryClient { | |||
| workspaceId, | |||
| { | |||
| query, | |||
| timespan | |||
| timespan, | |||
| workspaces: additionalWorkspaces?.map((x) => x) | |||
There was a problem hiding this comment.
I don't think you need this map here right?
There was a problem hiding this comment.
will it just copy it completely?
maorleger
approved these changes
Aug 5, 2021
KarishmaGhiya
force-pushed
the
monitor-query-workspaces
branch
from
895140f
to
ce0f506
Compare
KarishmaGhiya
changed the title
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Nov 17, 2021
[Hub Generated] Review request for Microsoft.BotService to add version preview/2021-05-01-preview (Azure#16760) * rename * change to enum * fix bug * fix example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update:
-Change the tests to last 2 days to combat slower ingestion times.