-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Batch] Rollback the support for TokenCredential #16870
Conversation
sdk/batch/batch/README.md
Outdated
|
||
### How to use | ||
1. Use `AzureCliCredentials` exported from `@azure/ms-rest-nodeauth`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the benefit of showing the Azure CLI option over the API key one? Can we skip this and showcase the API key scenario as that is what is shown in the official samples as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the readme used earlier, so I kept them to show case how to use nodeauth. To address your feedback, I deleted the CLI one and kept the shared key and the other nodeauth one.
7a96595
to
6704d61
Compare
@ramya-rao-a please take a look now. |
Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com>
* [Batch] Rollback the support for TokenCredential * address feedback * edit docstring * Update sdk/batch/batch/src/batchServiceClientContext.ts Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com> Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com>
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Track2 modify readme.go.md (Azure#16870)
Batch has been advertising using shared keys as their primary way of authentication in their docs. #16679 added support for
TokenCredential
authentication but it turned out that batch is not compatible with the support for token credentials in@azure/ms-rest-js
because the latter assumes a scope that only works with management-plane libs.If we want to fix the support for AAD, we will have to add support for custom scopes in
@azure/ms-rest-js
so we can pass the batch scopehttps://batch.core.windows.net//.default
to it and also updateazureTokenCredential
as follows:Because of the hassle of doing the fix and the fact that AAD support was not advertisied in batch to begin with, we want to go ahead and revert the support for
TokenCredential
instead.