-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Identity] OnBehalfOfCredential #16995
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is shaping up nicely! I wish there was an easy way to avoid sprinkling AuthenticationOptions
in so many places, but maybe this is the simplest solution and at least we'll have a place for other auth-related properties in the future
Co-authored-by: Jeff Fisher <xirzec@xirzec.com>
Tests are failing on Node12 on Windows. I’ll investigate |
Hi @sadasant. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
More complex designs of the OBO credential are not on the table for the foreseeable future. Closing this PR. |
This PR implements the
OnBehalfOfCredential
. This design to a while to figure out. You can read more about previous ideas through:After careful consideration of the possible impacts of all the options, we arrived back at the design originally proposed by @schaabs : To pass the
userAssertion
as an object besides the tracing parameters on theServiceClient
methods.This approach looks as follows:
Related to #15804
Fixes #17133
Work on a separate PR: