Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS for every mgmt package #17060

Merged
merged 3 commits into from
Aug 25, 2021
Merged

Conversation

ramya-rao-a
Copy link
Contributor

As discussed in Azure/azure-sdk-tools#1099, usage of glob patterns does not work for our bot. So adding codeowner for each of the mgmt plane package. I copied the list from https://github.com/Azure/azure-sdk-for-js/blob/feature/v4/eng/pipelines/mgmt-ci.yml

@ghost
Copy link

ghost commented Aug 24, 2021

Hello @ramya-rao-a!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost pushed a commit that referenced this pull request Aug 24, 2021
As discussed in Azure/azure-sdk-tools#1099, usage of glob patterns does not work for our bot. So adding codeowner for each of the mgmt plane package. I copied the list from https://github.com/Azure/azure-sdk-for-js/blob/feature/v4/eng/pipelines/mgmt-ci.yml

This was done in the main branch in #17060

Repeating it in the feature/v4 branch as this branch is used to make updates to the older versions of the mgmt plane packages
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run js - [service] - ci

.github/CODEOWNERS Outdated Show resolved Hide resolved
@qiaozha
Copy link
Member

qiaozha commented Aug 25, 2021

@ramya-rao-a hey, just out of curious why bot doesn't support this pattern match/sdk/**/arm-*/ @qiaozha @dw511214992

@qiaozha
Copy link
Member

qiaozha commented Aug 25, 2021

@ramya-rao-a hey, just out of curious why bot doesn't support this pattern match/sdk/**/arm-*/ @qiaozha @dw511214992

I see the details from the azure sdk tools issue now. Will this be a issue in feature/v4 branch as well ?

@ramya-rao-a
Copy link
Contributor Author

Will this be a issue in feature/v4 branch as well

Yes, I made this PR for that branch: #17061

Unfortunately the auto merge bot does not wait for PR approval if the PR is targeting a feature branch.
I have logged a separate issue for that Azure/azure-sdk-tools#1933

Co-authored-by: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com>
@ramya-rao-a
Copy link
Contributor Author

/check-enforcer override

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants