-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ReleasePR @azure/arm-quota] [QuotaRP] Fix LimitObject polymorphism #17365
Closed
openapi-sdkautomation
wants to merge
1
commit into
Azure:feature/v4
from
AzureSDKAutomation:sdkAuto/@azure_arm-quota
Closed
[ReleasePR @azure/arm-quota] [QuotaRP] Fix LimitObject polymorphism #17365
openapi-sdkautomation
wants to merge
1
commit into
Azure:feature/v4
from
AzureSDKAutomation:sdkAuto/@azure_arm-quota
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[QuotaRP] Split QuotaLimits API to - Usages and Quotas API (Azure#15416) * 1.Breaking Change - Removing duplicate autoQuotaIncreaseState from supportTicketAction. 2. Removing state=enabledForPreview. 3. Updating Example. * Updating Provider name in example. * Capacity RP Quota APIs for GA * Adding preview version to stable dir as base files. * Files from preview version, which will be removed. * Updating to GA Version. * 1. Updated reservation version tag to - Microsoft.Capacity/preview/2020-10-01-preview/reservations.json, which matches the previous SDK release. 2. Documentation changes. * Documentation updates for put and patch request, which includes only ONE quota request, so changing quotas to quota. * Update documenation for put. * Doc update. * Adding -preview tag for GO sdk. * Updating Go settings for output folder to be -preview. * Adding preview subdir for GO package. * Adding preview subdir to Go sdk path. * Removing tag - tag: package-2020-10-25-preview * introduce a new tag to keep the go sdk package unchanged * Revert "introduce a new tag to keep the go sdk package unchanged" This reverts commit 8f58d3451e9ae5a4746d2a5883911f14ca261f1b. * Adding Azure CLI readme configuration. * Updating the ReadMe configurations. * Updating readme.md * Removing duplicate cli: tag. * Fixing build issues. * Removing Parameter alias. * cli config changes. * Updating the package name to reservation. * Updates - removin .az.md. * Updating Example names to be unique for Get PUT * Adding operations and python-sdk-output-folder. * Updates. * Removing unused file. * Revert "Removing unused file." This reverts commit 4f763bdb14240a3f1ba8e1dce6c7f0b643ee6a9e. * Revert "Revert "Removing unused file."" This reverts commit 60c520e5b50bc13c42d8227624f32031c7ca7694. * Add reference to python readme.md file. * Adding python readme file. * Adding Operations for test-scenario * Adding split * Disabling few operation, which is not needed. * Removing split for Operation * Disabling the reservation Operations. * Disable reservation operations. * Revert "Disable reservation operations." This reverts commit d98cbcbafeb855395f9de45292dfc9db2f5aea9d. * Adding client-subscription-bound: false * Adding Network RP examples and references. * Updating Network Put and Patch requests. * Updating GetQuotaRequests example. * Fixing formatting. * Updating examples. * Adding error details for the quota request status. * Updating examples * Fixing formatting * Fixing model definition. * Revert "Fixing model definition." This reverts commit cef9f52f142cf6c420a5f89bd0e2d806e29530c1. * Updating example. * Making ResoureType as String, as it will change with different RPs and all possible values cannot be added in advance. * Adding Location header to Put and Path calls 200 response. * Adding example for Network StandardSkuPublicIpAddresses * Fixing spelling * Adding error code to Failed requests and updating examples. * Updating error message and code. * Updating example for Network - StandardSkuPublicIpAddresses * Adding oneOf construct. If supported, then I will update the examples. * Adding discriminator for Limit. * Adding discriminator to limit. * Updating network UsagesValue example for discriminator * Adding limitType definition. * Adding type to the Limit objects. * Updating type and example for discriminator * Updating type for discriminator * fixinf type definition for discriminator * Updating schema for discriminator and example. * Update network example. * Fixing network example. * Fixing schema. * Fixing network example. * Fix example. * Updating schema. * Updating schema and example. * Update example. * Examples update. * Update * Updated schema for discriminator * Adding value as required. * Schema Update. * Replace Limt with LimitObject to fix reference. * Updates. * Updates. * Updating Put/Ptach examples. * Updating erxamples. * Schema updated for requestStatus. * Schema Update. * Updates to QuotaRequestStatus example. Change api to quota. Add usages API and update examples reference. * 1. Split quotas and usages apis. 2. Add and update examples for quotas and usages. * Updating example filename references * Update Put example and operations id. * Updating limiType field to limitObjectType * Updating "limitType" to "limitObjectType" * Updating Get Examples. Adding extra property to quotas/limit object. * 1. Updating tags for usages. 2. Rename LimitObjectType to LimitObjectTypes. * Adding "limitType": "Independent" * Updating Operations Tag. * Updating subscription ids. * Updating Operations Name. * Updating the documentations and examples. * Updates. * Updates. * Updating Quota reference to base object type. * Updating examples and restoring the api name to quotaLimitsProviders. * Updating usages model and examples. * Update quotaLimitProviders to remove resourceQuery. * Revert "Update quotaLimitProviders to remove resourceQuery." This reverts commit 301092d496b2834d2e5110aa7b7f32c6f9802951. * Updating Operation API example for quotaLimitProviders rename. * Removing quotaLimitProviders API, as it's not needed by the azure portal. There wasn't a use case for the end user, that's why our team decided to remove it from public API. * 1. Removing unused models for quotaLimitProviders. 2. Update operations example. * Remove allof from usages. * 1. Updating 202 response schema. 2. Adding location header as per - https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/async-api-reference.md#updating-using-patch * Updating Patch 202 response model type. * Updating description of put and API api to check location header for detailed status. * Updates to description. * Update quota.json * Update quota.json Text scrub up to line 256 * Update quota.json Scrubbed all text strings. * Running prettier. * Updating Network examples to include resourceType. * Updating Networking Examples. * Remove 202 response body for Put and Patch. * preRemove example - putMachineLearningServicesQuotaRequestDedicated.json * Remove example - putMachineLearningServicesQuotaRequestDedicated.json Co-authored-by: Arcturus Zhang <dapzhang@microsoft.com> Co-authored-by: Pilar Ackerman <v-piacke@microsoft.com>
ghost
added
the
customer-reported
Issues that are reported by GitHub users external to the Azure organization.
label
Aug 31, 2021
17 tasks
Thank you for your contribution openapi-sdkautomation[bot]! We will review the pull request and get back to you soon. |
openapi-sdkautomation
bot
changed the title
[ReleasePR @azure/arm-quota] [QuotaRP] Split QuotaLimits API to - Usages and Quotas API
[ReleasePR @azure/arm-quota] Update readme and readme python
Sep 6, 2021
openapi-sdkautomation
bot
changed the title
[ReleasePR @azure/arm-quota] Update readme and readme python
[ReleasePR @azure/arm-quota] Updating tag value for Quota API
Sep 6, 2021
25 tasks
openapi-sdkautomation
bot
changed the title
[ReleasePR @azure/arm-quota] Updating tag value for Quota API
[ReleasePR @azure/arm-quota] Fix schemas readme files
Nov 1, 2021
25 tasks
openapi-sdkautomation
bot
changed the title
[ReleasePR @azure/arm-quota] Fix schemas readme files
[ReleasePR @azure/arm-quota] [QuotaRP] Fix LimitObject polymorphism
Nov 1, 2021
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
customer-reported
Issues that are reported by GitHub users external to the Azure organization.
0 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create to sync Azure/azure-rest-api-specs#16438
ReCreate this PR
Installation Instructions
You can install the package
@azure/arm-quota
of this PR using the following command:curl -L "https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/16438/azure-sdk-for-js/@azure_arm-quota/azure-arm-quota-1.0.0-beta.1.tgz" -o azure-arm-quota-1.0.0-beta.1.tgz npm install azure-arm-quota-1.0.0-beta.1.tgz
Direct Download
The generated package can be directly downloaded from here: