Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unified Recorder] @azure-tools/test-recorder-new Tool's roadmap #17989

Closed
wants to merge 5 commits into from
Closed

[Unified Recorder] @azure-tools/test-recorder-new Tool's roadmap #17989

wants to merge 5 commits into from

Conversation

HarshaNalluru
Copy link
Member

@HarshaNalluru HarshaNalluru commented Oct 1, 2021 •
edited
Loading

@sadasant suggested providing a clear roadmap for the recorder-new tool to have an idea of where we are leading towards.
This PR aims to provide that document.

This is an extract of the list of issues at #15829

Feel free to suggest edits and things if you feel something is missing.

@HarshaNalluru HarshaNalluru mentioned this pull request Oct 1, 2021
Merged
sadasant
sadasant reviewed Oct 1, 2021
View reviewed changes
sdk/test-utils/recorder-new/Roadmap.md Outdated
- 🔒 Corner cases - Example: Is it ok to start twice without calling stop?
- ✅ To make sure it works with our core-v1 and core-v2 packages all the way, start a standalone testing project which uses core-v1 and core-v2 sample SDKs and show how to leverage the recorder

## Merging with `@azure-tool/test-recorder` package
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should merge these or just deprecate the original package.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plan is to move to the original package since it already has been published, we'll migrate all of our SDKs and then remove the old features.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok ok

sadasant
sadasant reviewed Oct 1, 2021
View reviewed changes
Copy link
Contributor

@sadasant sadasant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not sure if this needs to live as a file in the repo. Though it’s pretty cool. Perhaps an epic would be more like how we’re used to do things?

@ramya-rao-a
Copy link
Contributor

I’m not sure if this needs to live as a file in the repo. Though it’s pretty cool. Perhaps an epic would be more like how we’re used to do things?

I agree with this. While it is nice to have a document for this, you will have to send a PR to make every tiny update. Consider either an epic or a wiki and then point to that from the readme of the new recorder package

@HarshaNalluru
Copy link
Member Author

Closing in favour of #15829

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Mar 7, 2022
@debroy @debjyoti11
@roeybc @laithhisham @ushasan @hassanchawiche @shschwar @royrein @dosegal @akning-ms
CodeGen from PR 18025 in Azure/azure-rest-api-specs
b83b241 
Dev sentinel 2022 01 01 preview (Azure#18025)

* Adds base for updating Microsoft.SecurityInsights from version preview/2021-10-01-preview to version 2022-01-01-preview

* Updates readme

* Updates API version in new specs and examples

* SourceControl API 2022-01-01-preview version - adding new attribute to SourceControl model (Azure#17849)

* SourceControl 2022-01-01-preview version change

* fix validation error

* prettified

* prettified

Co-authored-by: debjyoti11 <debjyotiroy88@gmail.com>

* New metadata API (Azure#17942)

* metadata changes

* addressed changes

* updated enum kind

* updated values as well

Co-authored-by: Roey Ben Chaim <robencha@microsoft.com>

* added new enum to kind (Azure#17994)

Co-authored-by: Roey Ben Chaim <robencha@microsoft.com>

* Add flag to rotate webhook secret (Azure#17989)

Co-authored-by: debjyoti11 <debjyotiroy88@gmail.com>

* Align definitions with stable version (Azure#17931)

* Align definitions with stable version

* align scheduled rule and template properties with stable

* Note: We are creating a new api-version with this change. Watchlists.json 2022-01-01-preview parameter name changes (Azure#17848)

* changed source to sourceType and watchlistAlias to alias

* Update CreateWatchlistAndWatchlistItems.json

* Update CreateWatchlistItem.json

* Update DeleteWatchlist.json

* Update DeleteWatchlistItem.json

* Update GetWatchlistByAlias.json

* Update GetWatchlistItemById.json

* Update GetWatchlistItems.json

* Update GetWatchlistByAlias.json

* added missing params to match stable version

* Revert "added missing params to match stable version"

This reverts commit a30a709613f94266d0eaba6495c92be43221a282.

Reverting by 1 commit

* refreshing pipeline

* reverting lint diff change

* attempting to fix RemovedPath breaking changes

* Revert "attempting to fix RemovedPath breaking changes"

This reverts commit 2f96ee3c050fde4c166bf730b0a1b5faff07cfc1.

reverting attempt at correcting breaking changes. cannot match preview
to stable without breaking everything.

* adding back source type for backwards compatibility, added response descriptions, corrected PR comments

* adding missing bracket

* ran npm run prettier-fix to correct style issues

* resolving model/definition errors

* Revert "resolving model/definition errors"

This reverts commit fd67a4f813d923965cefad50999010820446a107.

Reverting prettier changes made to other branches

* Revert "ran npm run prettier-fix to correct style issues"

This reverts commit 3055791e00e956fff3a62e24d8313dde96daa00c.

* update

* Update DeleteWatchlist.json

* Update Watchlists.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* fixing styling issues on Delete example

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* ran npm run prettier on DeleteWatchlist.json

* Update Watchlists.json

* reverting alias to watchlistAlias

Co-authored-by: Hassan Chawiche <hassanc@microsoft.com>

* Rename system to AutoAssigned (Azure#18061)

* Rename system to AutoAssigned

* Add example to list operations

* Update API version in NRT examples

* Execute validation tools and fix results (Azure#17733)

* Execute validation tools and fic results

* Prettyfieir GetIoTById.json

* Watchlists.json-2022-01-01-preview-parameterNameChanges (reverted PR reference for files changed -> https://github.com/Azure/azure-rest-api-specs/pull/17848/files) (Azure#18085)

* changed source to sourceType and watchlistAlias to alias

* Update CreateWatchlistAndWatchlistItems.json

* Update CreateWatchlistItem.json

* Update DeleteWatchlist.json

* Update DeleteWatchlistItem.json

* Update GetWatchlistByAlias.json

* Update GetWatchlistItemById.json

* Update GetWatchlistItems.json

* Update GetWatchlistByAlias.json

* added missing params to match stable version

* Revert "added missing params to match stable version"

This reverts commit a30a709613f94266d0eaba6495c92be43221a282.

Reverting by 1 commit

* refreshing pipeline

* reverting lint diff change

* attempting to fix RemovedPath breaking changes

* Revert "attempting to fix RemovedPath breaking changes"

This reverts commit 2f96ee3c050fde4c166bf730b0a1b5faff07cfc1.

reverting attempt at correcting breaking changes. cannot match preview
to stable without breaking everything.

* adding back source type for backwards compatibility, added response descriptions, corrected PR comments

* adding missing bracket

* ran npm run prettier-fix to correct style issues

* resolving model/definition errors

* Revert "resolving model/definition errors"

This reverts commit fd67a4f813d923965cefad50999010820446a107.

Reverting prettier changes made to other branches

* Revert "ran npm run prettier-fix to correct style issues"

This reverts commit 3055791e00e956fff3a62e24d8313dde96daa00c.

* update

* Update DeleteWatchlist.json

* Update Watchlists.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* fixing styling issues on Delete example

* Update DeleteWatchlist.json

* Update DeleteWatchlist.json

* ran npm run prettier on DeleteWatchlist.json

* Update Watchlists.json

* reverting alias to watchlistAlias

* fixing type version

* Update Watchlists.json

* Update DeleteWatchlist.json

* fixing commas

Co-authored-by: Hassan Chawiche <hassanc@microsoft.com>
Co-authored-by: Usman Hasan <usman.hasan@microsoft.com>

* Done (Azure#17843)

Co-authored-by: Roy Reinhorn <roreinho@microsoft.com>

* AutomationRules 2022-01-01-preview: Add constraints (Azure#18099)

* add contraints (alinged with the latest stable version)

Co-authored-by: debroy <debjyoti.iitkgp@gmail.com>
Co-authored-by: debjyoti11 <debjyotiroy88@gmail.com>
Co-authored-by: RoeyBC <roey.benhaim@gmail.com>
Co-authored-by: Roey Ben Chaim <robencha@microsoft.com>
Co-authored-by: Laith Hisham <49263932+laithhisham@users.noreply.github.com>
Co-authored-by: ushasan <69323982+ushasan@users.noreply.github.com>
Co-authored-by: Hassan Chawiche <hassanc@microsoft.com>
Co-authored-by: shschwar <55053268+shschwar@users.noreply.github.com>
Co-authored-by: Usman Hasan <usman.hasan@microsoft.com>
Co-authored-by: royrein <37300636+royrein@users.noreply.github.com>
Co-authored-by: Roy Reinhorn <roreinho@microsoft.com>
Co-authored-by: dosegal <51155368+dosegal@users.noreply.github.com>
Co-authored-by: Arthur Ning <57385816+akning-ms@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadasant sadasant sadasant left review comments

@jeremymeng jeremymeng Awaiting requested review from jeremymeng

@maorleger maorleger Awaiting requested review from maorleger

@chradek chradek Awaiting requested review from chradek

@scbedd scbedd Awaiting requested review from scbedd

@ramya-rao-a ramya-rao-a Awaiting requested review from ramya-rao-a

@deyaaeldeen deyaaeldeen Awaiting requested review from deyaaeldeen

@witemple-msft witemple-msft Awaiting requested review from witemple-msft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HarshaNalluru @ramya-rao-a @sadasant