[core] Added logger parameters to bearerTokenAuthenticationPolicy #18467
Conversation
sadasant
requested review from
bterlson,
deyaaeldeen,
jeremymeng and
ramya-rao-a
as code owners
ghost
added
the
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
|
API changes have been detected in API changes + logger?: AzureLogger;
+ logger?: AzureLogger;
+ logger?: AzureLogger; |
|
The implementation looks good. Maybe we could have an example of how this would be used? Like, take the logger from a SDK package you're using CAE with and passing that logger as the logger for this thing? @bterlson @jeremymeng what do you think? |
…am (Azure#18492) * Add responseAsStream to PipelineRequest * Use Number.POSITIVE_INFINITY to indicate that any status code should get raw response * Remove unneeded property in client request and address comments * Update changelog
sadasant
force-pushed
the
core-client/cae-logger
branch
from
3e33a75
to
b571371
Compare
| allParams.map((x) => x.join(" ")).join("\n"), | ||
| `The WWW-Authenticate header was missing the necessary "claims" to perform the Continuous Access Evaluation authentication flow.` | ||
| ); | ||
| }); |
There was a problem hiding this comment.
@xirzec I have added unit tests 🎉
There was a problem hiding this comment.
I like this change! Since I suggested it though, can @bterlson or @jeremymeng give their thoughts on the addition?
|
API changes have been detected in API changes + logger?: AzureLogger;
+ logger?: AzureLogger;
+ logger?: AzureLogger; |
This PR allows customizing the internal logger of the
authorizeRequestOnClaimChallengechallenge provided by the@azure/core-client. Client developers would need to send the logger through at the moment they initialize thebearerTokenAuthenticationPolicy. Currently, there are no other uses for this logger in thebearerTokenAuthenticationPolicy, but this opens us to the possibility of adding more logging in the future.This is based on feedback from @xirzec here: #17315 (comment)