Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update @azure/identity dependency on REST Clients to v2 #18536

Merged
merged 7 commits into from
Nov 4, 2021
Merged

Update @azure/identity dependency on REST Clients to v2 #18536

merged 7 commits into from
Nov 4, 2021

Conversation

joheredi
Copy link
Member

@joheredi joheredi commented Nov 4, 2021

Update Rest Clients to identity v2

ramya-rao-a
ramya-rao-a approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few places that use ^2.0.0 and others with ^2.0.1. We should be consistent with the latter. But wont block the PR on this :)

Can you send a separate PR to use ^2.0.1?

@ramya-rao-a ramya-rao-a merged commit b9c9779 into Azure:main Nov 4, 2021
@ramya-rao-a
Copy link
Contributor

Related to #14581

sadasant pushed a commit to sadasant/azure-sdk-for-js that referenced this pull request Nov 6, 2021
@joheredi
Update @azure/identity dependency on REST Clients to v2 (Azure#18536)
7460bd1 
* Purview Administration

* Purview Catalog

* Purview Account

* Purview scanning

* Farmbeats

* ConfidentialLedger

* DocumentTranslator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramya-rao-a ramya-rao-a ramya-rao-a approved these changes

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya

@HarshaNalluru HarshaNalluru Awaiting requested review from HarshaNalluru

@qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner

Assignees
No one assigned
Labels
AgriFood Cognitive - Translator Confidential Ledger Purview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joheredi @ramya-rao-a