-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eslint] - fix plugin rule list #18771
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maorleger
requested review from
deyaaeldeen,
mikeharder,
praveenkuttappan and
witemple-msft
as code owners
November 22, 2021 18:23
ghost
added
the
eslint plugin
label
Nov 22, 2021
Nice catch! |
ramya-rao-a
approved these changes
Nov 22, 2021
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Apr 22, 2022
Enable azure-powershell CI for all management RPs (Azure#18771) * Enable azure-powershell for all manage RPs * Change integrationRepository to Azure/azure-powershell-pr * Change azure-powershell in api-spec repo * Change azure-powershell in api-spec repo * Remove azure-powershell from some deprecated RPs Co-authored-by: v-yuzhichen@microsoft.com <v-yuzhichen@microsoft.com>
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Apr 22, 2022
Enable azure-powershell CI for all management RPs (Azure#18771) * Enable azure-powershell for all manage RPs * Change integrationRepository to Azure/azure-powershell-pr * Change azure-powershell in api-spec repo * Change azure-powershell in api-spec repo * Remove azure-powershell from some deprecated RPs Co-authored-by: v-yuzhichen@microsoft.com <v-yuzhichen@microsoft.com>
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Apr 22, 2022
Enable azure-powershell CI for all management RPs (Azure#18771) * Enable azure-powershell for all manage RPs * Change integrationRepository to Azure/azure-powershell-pr * Change azure-powershell in api-spec repo * Change azure-powershell in api-spec repo * Remove azure-powershell from some deprecated RPs Co-authored-by: v-yuzhichen@microsoft.com <v-yuzhichen@microsoft.com>
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Apr 22, 2022
Enable azure-powershell CI for all management RPs (Azure#18771) * Enable azure-powershell for all manage RPs * Change integrationRepository to Azure/azure-powershell-pr * Change azure-powershell in api-spec repo * Change azure-powershell in api-spec repo * Remove azure-powershell from some deprecated RPs Co-authored-by: v-yuzhichen@microsoft.com <v-yuzhichen@microsoft.com>
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Apr 22, 2022
Enable azure-powershell CI for all management RPs (Azure#18771) * Enable azure-powershell for all manage RPs * Change integrationRepository to Azure/azure-powershell-pr * Change azure-powershell in api-spec repo * Change azure-powershell in api-spec repo * Remove azure-powershell from some deprecated RPs Co-authored-by: v-yuzhichen@microsoft.com <v-yuzhichen@microsoft.com>
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Apr 22, 2022
Enable azure-powershell CI for all management RPs (Azure#18771) * Enable azure-powershell for all manage RPs * Change integrationRepository to Azure/azure-powershell-pr * Change azure-powershell in api-spec repo * Change azure-powershell in api-spec repo * Remove azure-powershell from some deprecated RPs Co-authored-by: v-yuzhichen@microsoft.com <v-yuzhichen@microsoft.com>
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Apr 22, 2022
Enable azure-powershell CI for all management RPs (Azure#18771) * Enable azure-powershell for all manage RPs * Change integrationRepository to Azure/azure-powershell-pr * Change azure-powershell in api-spec repo * Change azure-powershell in api-spec repo * Remove azure-powershell from some deprecated RPs Co-authored-by: v-yuzhichen@microsoft.com <v-yuzhichen@microsoft.com>
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Apr 22, 2022
Enable azure-powershell CI for all management RPs (Azure#18771) * Enable azure-powershell for all manage RPs * Change integrationRepository to Azure/azure-powershell-pr * Change azure-powershell in api-spec repo * Change azure-powershell in api-spec repo * Remove azure-powershell from some deprecated RPs Co-authored-by: v-yuzhichen@microsoft.com <v-yuzhichen@microsoft.com>
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Apr 22, 2022
Enable azure-powershell CI for all management RPs (Azure#18771) * Enable azure-powershell for all manage RPs * Change integrationRepository to Azure/azure-powershell-pr * Change azure-powershell in api-spec repo * Change azure-powershell in api-spec repo * Remove azure-powershell from some deprecated RPs Co-authored-by: v-yuzhichen@microsoft.com <v-yuzhichen@microsoft.com>
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Apr 22, 2022
Enable azure-powershell CI for all management RPs (Azure#18771) * Enable azure-powershell for all manage RPs * Change integrationRepository to Azure/azure-powershell-pr * Change azure-powershell in api-spec repo * Change azure-powershell in api-spec repo * Remove azure-powershell from some deprecated RPs Co-authored-by: v-yuzhichen@microsoft.com <v-yuzhichen@microsoft.com>
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Apr 22, 2022
Enable azure-powershell CI for all management RPs (Azure#18771) * Enable azure-powershell for all manage RPs * Change integrationRepository to Azure/azure-powershell-pr * Change azure-powershell in api-spec repo * Change azure-powershell in api-spec repo * Remove azure-powershell from some deprecated RPs Co-authored-by: v-yuzhichen@microsoft.com <v-yuzhichen@microsoft.com>
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Apr 22, 2022
Enable azure-powershell CI for all management RPs (Azure#18771) * Enable azure-powershell for all manage RPs * Change integrationRepository to Azure/azure-powershell-pr * Change azure-powershell in api-spec repo * Change azure-powershell in api-spec repo * Remove azure-powershell from some deprecated RPs Co-authored-by: v-yuzhichen@microsoft.com <v-yuzhichen@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like ts-package-json-sdktype rule entry was duplicated in #18597 -
which casues the "number of rules should match the expected value" to report an
error.
This PR fixes the issue by removing the duplicated entry. I also went ahead and
sorted the entries to make these things easier to spot in the future (although
there is no guarantee sort will be preserved).