Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating CODEOWNERS Communication NetworkTraversal #21964

Merged
merged 1 commit into from
May 23, 2022
Merged

Conversation

ajpeacock0
Copy link
Contributor

Packages impacted by this PR

Issues associated with this PR

Describe the problem that is addressed by this PR

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@ajpeacock0 ajpeacock0 requested a review from jsquire as a code owner May 23, 2022 20:24
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run js - [service] - ci

@jsquire
Copy link
Member

jsquire commented May 23, 2022

/check-enforcer override

@jsquire jsquire merged commit 13db520 into main May 23, 2022
@jsquire jsquire deleted the ajpeacock0-patch-1 branch May 23, 2022 21:36
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this pull request Jan 16, 2023
Dev search microsoft.search 2022 09 01 (Azure#21964)

* Adds base for updating Microsoft.Search from version stable/2020-08-01 to version 2022-09-01

* Updates readme

* Updates API version in new specs and examples

* Add missing private endpoint connection properties (Azure#21629)

* add missing private endpoint connection properties

* fix errors

* Adding delegated identities to data plane

* Revert "Adding delegated identities to data plane"

This reverts commit def1bd3ba296458c19b8f04cb1a7a5b800d002f9.

* Fix Lint ProvisioningStateValidation Error

* Applying prettier changes
npm run prettier -- --write

Co-authored-by: Enrique Jaimes <enjaimes@microsoft.com>

* Satumkur/new api ver 20220901 (Azure#21922)

* semantic updates

* Add Dataplane RBAC related changes + examples

* Prettier fixes

* Fix LintDiff errors

* Update SearchUpdateServiceDisableLocalAuth.json

update erroneous api version param

Co-authored-by: Samartha Tumkur Vani <satumkur@microsoft.com>
Co-authored-by: Enrique Jaimes <enjaimes@microsoft.com>

* Add CMK Enforcement policy support (Azure#21996)

* Add CMK Enforcement policy support

* Update api-version

* Remove unused properties

* Remove bypass property

Co-authored-by: satumkurmsft <72990508+satumkurmsft@users.noreply.github.com>
Co-authored-by: Matt <57731498+mattmsft@users.noreply.github.com>
Co-authored-by: Samartha Tumkur Vani <satumkur@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants