[dev-tool] Remove stale sample guardrails #24148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
witemple-msft
requested review from
praveenkuttappan and
deyaaeldeen
as code owners
jeremymeng
reviewed
Dec 6, 2022
| @@ -224,7 +224,7 @@ export const commandInfo = makeCommandInfo( | |||
| "node-versions": { | |||
| kind: "string", | |||
| description: "A comma separated list of node versions to use", | |||
| default: "12,14,16,17", | |||
| default: "14,16,17", | |||
There was a problem hiding this comment.
should we remove 17 and add 18,19?
jeremymeng
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes outdated syntax restrictions from dev-tool when generating samples. This follows the end of our Node.js 12 grace period. Additionally, it increases the compiler target in samples from ES2018 to ES2020.
I've also removed version 12 from the default
check-node-versionsconfiguration.CC @xirzec