Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web-pubsub-client] Fix isDuplicated always returned as true #25239

Merged
1 commit merged into from
Mar 27, 2023

Conversation

zackliu
Copy link
Member

@zackliu zackliu commented Mar 14, 2023

Packages impacted by this PR

@azure/web-pubsub-client

Issues associated with this PR

#24901
#24902 try to fix this issue but blocked by format.

Describe the problem that is addressed by this PR

IsDuplicated always return true in WebPubSubResult.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@ghost ghost added the WebPubSub label Mar 14, 2023
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@ghost
Copy link

ghost commented Mar 27, 2023

Hello @zackliu!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit d67a195 into Azure:main Mar 27, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants