Consume start and end partition and row keys #25293

joheredi · 2023-03-17T21:58:39Z

Packages impacted by this PR

@azure/data-tables

Issues associated with this PR

Describe the problem that is addressed by this PR

We accept startPartitionKey, startRowKey, endPartitionKey and endRowKey parameters when generating table sas token. However internally we are ignoring those provided values.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

To fix this problem we simply need to plumb the values through

Are there test cases added in this PR? (If not, why?)

YES

Provide a list of related PRs (if any)

N/A

azure-sdk · 2023-03-17T22:09:30Z

API change check

API changes are not detected in this pull request.

craxal · 2023-03-20T16:38:00Z

sdk/tables/data-tables/test/internal/node/generateSas.spec.ts

@@ -37,6 +39,28 @@ describe("SAS generation", function () {
      assert.equal(tableSas, expectedSas1);
    });

+    it("should generate a SAS token with start partition and row keys", async () => {


Mocha explicitly states that arrow functions are discouraged, because they cannot access the Mocha context available in this:

https://mochajs.org/#arrow-functions

yes, we even have a work item tracking changing arrow functions to regular functions #13005.

Well, I guess today is the day for Tables. I have migrated all the tests from arrow functions to anonymous functions.

jeremymeng

Looks good. I added some minor comments

sdk/tables/data-tables/src/sas/sasQueryParameters.ts

ghost · 2023-03-23T16:24:43Z

Hello @joheredi!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

Release sql microsoft.sql 2023 02 01 preview (Azure#25293) * Adds base for updating Microsoft.Sql from version preview/2022-11-01-preview to version 2023-02-01-preview * Updates readme * Updates API version in new specs and examples * add mi refresh API (Azure#24093) * add mi refresh API * remove stray character * add examples * fix lro error * fix lro error only in example * fixing prettier issue * Test commit - adding error schema * Test2 * Test - changing error type * Revert "Test - changing error type" This reverts commit 84fff94ea9cefca5312d2f5c12e099f315e0c064. * Reverting 3 test commits * Test - adding commong error type reference * fix type format errors --------- Co-authored-by: Stefan Krivokapic <skrivokapic@microsoft.com> * Adding changes from main to release branch. PRs 24175 and 24185 (Azure#24221) * Enable multiple partner servers and failover of read-only endpoint for SQL DB Failover Group in version 2023-02-01-preview. (Azure#24132) * Added the swagger spec and example json files for failvoer group API update in V2023-020-1 * Corrected the FailoverGroupGet.json example * Updated the auto-generated FailoverGroups.json Fixed FailoverGroups.json swagger arm-id attribute for databases field * Added the missing headers field manually * Fix FailoverGroups.json --------- Co-authored-by: Sharan Singh <sharanlobana@gmail.com> * Changes to Location Capabilities (Azure#24209) * Loc cap changes * removing changes not related to my changes in dsmain * DAG API 2023-02-01 (Azure#24108) * add new dag api version * Update swagger * Update swagger * patch resource * make replicationMode writable * Add FreeLimitExhaustion Capability in 2023-02-01-preview API (Azure#24224) * Add FreeLimitExhaustion Capability in 2023-02-01-preview API * Change property from name to exhaustionBehaviorType * generate swagger for LocationCapabilites (Azure#24290) * inital commit for LTR Policy Immutability (Azure#24347) * inital commit for immutable ltr backups (Azure#24349) * Update Servers swagger files with adding property "IsIPv6Enabled" (Azure#24305) * Update swagger files for Server API * Add v5 tag for Servers * Restore none for minimal TLS version * Add auto rotation param to databases api (Azure#24339) * Add auto rotation param to databases api * add armid * Adding IsFreemium and CreateTime to Get MI API (Azure#24239) * Updated the examples for LTR Policies and LTR Backups (Azure#24821) * Updated the examples for LTR Policies and LTR Backups * Not sure why makeBackupsImmutable got deleted * updating swagger files for enum name changes (Azure#24742) * Carrying over minor changes for the 2023-02-01-preview release (Azure#25177) * Carrying over minor changes for the 2023-02-01-preview release * Reverting example files that didn't have DsMainDev side changes, and fixing prettier check * Fixes for LTR examples with model validation and prettier check for ServerDelete * Reverting LTR changes * Adding arm-id to serversjson * swagger changes for adding new parameter in dc telemetry (Azure#24834) * testing push * reverting push * swagger files for DC add parameter change * delete added file * modified swagger files without Venkat's change * modified swagger files * changed modelAsString to true * add example files * add example files * fix mismatch * Removing Pattern from ManagedInstance to avoid incident (Azure#25295) * Carrying over minor changes for the 2023-02-01-preview release * Reverting example files that didn't have DsMainDev side changes, and fixing prettier check * Fixes for LTR examples with model validation and prettier check for ServerDelete * Reverting LTR changes * Adding arm-id to serversjson * Removing the Pattern property from ManagedInstances.json as it should not be present and will cause issues in downstream client generation --------- Co-authored-by: guptanitish-ms <68623376+guptanitish-ms@users.noreply.github.com> Co-authored-by: Stefan Krivokapic <skrivokapic@microsoft.com> Co-authored-by: lobashh <56324552+lobashh@users.noreply.github.com> Co-authored-by: Sharan Singh <sharanlobana@gmail.com> Co-authored-by: Aleksand4rZivanovic <60347245+Aleksand4rZivanovic@users.noreply.github.com> Co-authored-by: a-lazarlazic <106240189+a-lazarlazic@users.noreply.github.com> Co-authored-by: mykolian <34487118+mykolian@users.noreply.github.com> Co-authored-by: Srna Nikolic <133877309+srnanikolicmdcs@users.noreply.github.com> Co-authored-by: rebeccaxu-ms <104461363+rebeccaxu-ms@users.noreply.github.com> Co-authored-by: LeiWang3 <84884417+LeiWang3@users.noreply.github.com> Co-authored-by: viparek <78561564+viparek@users.noreply.github.com> Co-authored-by: Nikola Mirkovic <135128634+nmirkovic-microsoft@users.noreply.github.com> Co-authored-by: pmahanandire <104351468+pmahanandire@users.noreply.github.com> Co-authored-by: nidhigupta <139312437+Nidhi-Gupta6198@users.noreply.github.com>

ghost added the Tables label Mar 17, 2023

joheredi requested review from jeremymeng and JonathanCrd March 17, 2023 21:59

craxal reviewed Mar 20, 2023

View reviewed changes

jeremymeng approved these changes Mar 22, 2023

View reviewed changes

Consume start and end partition and row keys

b7abc8d

joheredi force-pushed the tables-srk branch from 806c330 to b7abc8d Compare March 23, 2023 16:23

Address PR Comments

87bb555

joheredi added the auto-merge label Mar 23, 2023

ghost merged commit a290531 into Azure:main Mar 23, 2023

joheredi mentioned this pull request Mar 23, 2023

[data-tables] SAS options do not appear in generated SAS, rendering it useless #25252

Closed

6 tasks

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Consume start and end partition and row keys #25293

Consume start and end partition and row keys #25293

joheredi commented Mar 17, 2023

azure-sdk commented Mar 17, 2023

craxal Mar 20, 2023

jeremymeng Mar 22, 2023

joheredi Mar 23, 2023

jeremymeng left a comment

ghost commented Mar 23, 2023

Consume start and end partition and row keys #25293

Consume start and end partition and row keys #25293

Conversation

joheredi commented Mar 17, 2023

Packages impacted by this PR

Issues associated with this PR

Describe the problem that is addressed by this PR

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

azure-sdk commented Mar 17, 2023

craxal Mar 20, 2023

Choose a reason for hiding this comment

jeremymeng Mar 22, 2023

Choose a reason for hiding this comment

joheredi Mar 23, 2023

Choose a reason for hiding this comment

jeremymeng left a comment

Choose a reason for hiding this comment

ghost commented Mar 23, 2023

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.