Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mgmt] cdn release #27380

Merged
merged 7 commits into from
Oct 25, 2023
Merged

[mgmt] cdn release #27380

merged 7 commits into from
Oct 25, 2023

Conversation

kazrael2119
Copy link
Contributor

@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Oct 11, 2023
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-arm-cdn

jeremymeng
jeremymeng previously requested changes Oct 16, 2023
View reviewed changes
Copy link
Member

@jeremymeng jeremymeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node and mocha version has been upgraded

@MaryGao MaryGao requested a review from jeremymeng October 24, 2023 06:46
@qiaozha qiaozha dismissed jeremymeng’s stale review October 25, 2023 07:14

should have been resolved.

MaryGao
MaryGao approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaryGao MaryGao merged commit 03c798c into Azure:main Oct 25, 2023
22 checks passed
@kazrael2119 kazrael2119 deleted the cdn-re branch October 25, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaryGao MaryGao MaryGao approved these changes

@witemple-msft witemple-msft Awaiting requested review from witemple-msft

@deyaaeldeen deyaaeldeen Awaiting requested review from deyaaeldeen

@ckairen ckairen Awaiting requested review from ckairen ckairen is a code owner

@qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner

@jeremymeng jeremymeng Awaiting requested review from jeremymeng jeremymeng is a code owner

Assignees
No one assigned
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kazrael2119 @azure-sdk @jeremymeng @MaryGao