[mgmt] containerservice release #30510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Mgmt
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
qiaozha
approved these changes
Jul 25, 2024
Not sure why this pr is still requesting review from azure-sdk-for-js-core? Feel like it's because of the api.md file change, but since I am on the owner list, curious why it's not working ? @jeremymeng @xirzec
|
|
@qiaozha it is the tsconfig.json. I will try adding another entry |
|
@qiaozha I guess the pattern didn't work azure-sdk-for-js/.github/CODEOWNERS Line 1557 in fe18ae3 |
|
@jeremymeng thanks for taking care of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/Azure/sdk-release-request/issues/5322
breaking caused by Azure/azure-rest-api-specs#29535