-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[monitor-opentelemetry] Live Metrics Filtering (for charts) #31062
Merged
harsimar
merged 14 commits into
Azure:main
from
harsimar:harskaur/liveMetricsFiltering2
Sep 27, 2024
Merged
[monitor-opentelemetry] Live Metrics Filtering (for charts) #31062
harsimar
merged 14 commits into
Azure:main
from
harsimar:harskaur/liveMetricsFiltering2
Sep 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorhdzg
changed the title
Live Metrics Filtering (for charts)
[monitor-opentelemetry] Live Metrics Filtering (for charts)
Sep 11, 2024
API change check API changes are not detected in this pull request. |
hectorhdzg
reviewed
Sep 24, 2024
sdk/monitor/monitor-opentelemetry/src/metrics/quickpulse/filtering.ts
Outdated
Show resolved
Hide resolved
hectorhdzg
reviewed
Sep 24, 2024
sdk/monitor/monitor-opentelemetry/src/metrics/quickpulse/filtering.ts
Outdated
Show resolved
Hide resolved
hectorhdzg
reviewed
Sep 24, 2024
sdk/monitor/monitor-opentelemetry/src/metrics/quickpulse/filtering.ts
Outdated
Show resolved
Hide resolved
hectorhdzg
reviewed
Sep 24, 2024
sdk/monitor/monitor-opentelemetry/src/metrics/quickpulse/filtering.ts
Outdated
Show resolved
Hide resolved
hectorhdzg
reviewed
Sep 24, 2024
sdk/monitor/monitor-opentelemetry/test/internal/unit/metrics/liveMetrics.test.ts
Show resolved
Hide resolved
hectorhdzg
reviewed
Sep 24, 2024
sdk/monitor/monitor-opentelemetry/src/metrics/quickpulse/utils.ts
Outdated
Show resolved
Hide resolved
hectorhdzg
reviewed
Sep 25, 2024
hectorhdzg
reviewed
Sep 25, 2024
sdk/monitor/monitor-opentelemetry/src/metrics/quickpulse/utils.ts
Outdated
Show resolved
Hide resolved
hectorhdzg
reviewed
Sep 25, 2024
sdk/monitor/monitor-opentelemetry/src/metrics/quickpulse/utils.ts
Outdated
Show resolved
Hide resolved
hectorhdzg
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
monitor-opentelemetry
Describe the problem that is addressed by this PR
This PR adds live metrics filtering, for the metrics charts.
The change to fix the document spam bug is also here, but I will also create a separate PR just for that.
There are a few things I didn't include in this PR that will be included separate future PRs:
Are there test cases added in this PR? (If not, why?)
Yes
Checklists