Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[monitor-opentelemetry] Live Metrics Filtering (for charts) #31062

Merged
merged 14 commits into from
Sep 27, 2024

Conversation

harsimar
Copy link
Member

Packages impacted by this PR

monitor-opentelemetry

Describe the problem that is addressed by this PR

This PR adds live metrics filtering, for the metrics charts.
The change to fix the document spam bug is also here, but I will also create a separate PR just for that.

There are a few things I didn't include in this PR that will be included separate future PRs:

  • filtering for documents on right hand pane. Currently this change just emits all documents.
  • changes to how CPU/Mem are to be collected for live metrics (per process counters).
  • Retry/caching logic for requests made to QuickPulse. Currently this PR does not change this behavior, but for future parity with spec we should consider caching live metrics data points when post requests fail & reducing retries if there is a network error (considering ping/post happens every few seconds anyway).

Are there test cases added in this PR? (If not, why?)

Yes

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@hectorhdzg hectorhdzg changed the title Live Metrics Filtering (for charts) [monitor-opentelemetry] Live Metrics Filtering (for charts) Sep 11, 2024
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Member

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harsimar harsimar merged commit f7d0b98 into Azure:main Sep 27, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants