Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dev dependency eslint #4762

Merged
merged 4 commits into from
Aug 14, 2019
Merged

Update dev dependency eslint #4762

merged 4 commits into from
Aug 14, 2019

Conversation

mikeharder
Copy link
Member

@mikeharder mikeharder commented Aug 14, 2019 •
edited
Loading

  • Replaced eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
  • eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient

@mikeharder mikeharder marked this pull request as ready for review August 14, 2019 01:51
XiaoningLiu
XiaoningLiu approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@XiaoningLiu XiaoningLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good for storage.

@mikeharder mikeharder merged commit c303d91 into Azure:master Aug 14, 2019
@mikeharder mikeharder deleted the update-eslint branch August 14, 2019 17:16
pull bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Aug 14, 2019
@mikeharder @pull
Update dev dependency eslint (#4762)
6956753 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Aug 26, 2019
@mikeharder
Update dev dependency eslint (#4762)
43ced2d 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-bot-test bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Aug 26, 2019
@mikeharder
Update dev dependency eslint (#4762)
bea085a 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-bot-test bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Aug 27, 2019
@mikeharder
Update dev dependency eslint (#4762)
7cee19e 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-bot-test bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Aug 27, 2019
@mikeharder
Update dev dependency eslint (#4762)
fe723b3 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Aug 30, 2019
@mikeharder
Update dev dependency eslint (#4762)
b972ebf 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Aug 30, 2019
@mikeharder
Update dev dependency eslint (#4762)
d471120 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Sep 3, 2019
@mikeharder
Update dev dependency eslint (#4762)
7dcc51e 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Oct 7, 2019
@mikeharder
Update dev dependency eslint (#4762)
5334dab 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Oct 7, 2019
@mikeharder
Update dev dependency eslint (#4762)
58da383 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Oct 7, 2019
@mikeharder
Update dev dependency eslint (#4762)
4da1529 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Oct 7, 2019
@mikeharder
Update dev dependency eslint (#4762)
81e338f 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Oct 7, 2019
@mikeharder
Update dev dependency eslint (#4762)
0859433 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Oct 7, 2019
@mikeharder
Update dev dependency eslint (#4762)
e120837 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Oct 7, 2019
@mikeharder
Update dev dependency eslint (#4762)
ec0de4d 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Oct 7, 2019
@mikeharder
Update dev dependency eslint (#4762)
8f5a588 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Oct 7, 2019
@mikeharder
Update dev dependency eslint (#4762)
ea302ff 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Oct 7, 2019
@mikeharder
Update dev dependency eslint (#4762)
07d69ad 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Oct 7, 2019
@mikeharder
Update dev dependency eslint (#4762)
dc4f3d5 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Oct 7, 2019
@mikeharder
Update dev dependency eslint (#4762)
22cd66c 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Oct 7, 2019
@mikeharder
Update dev dependency eslint (#4762)
f0a3667 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Oct 7, 2019
@mikeharder
Update dev dependency eslint (#4762)
23a709c 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Oct 7, 2019
@mikeharder
Update dev dependency eslint (#4762)
8a50b11 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Oct 7, 2019
@mikeharder
Update dev dependency eslint (#4762)
ddcf4e5 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Oct 7, 2019
@mikeharder
Update dev dependency eslint (#4762)
0517b11 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Oct 7, 2019
@mikeharder
Update dev dependency eslint (#4762)
babbc70 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Oct 7, 2019
@mikeharder
Update dev dependency eslint (#4762)
cdf93a5 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Oct 7, 2019
@mikeharder
Update dev dependency eslint (#4762)
f4c98e6 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Oct 7, 2019
@mikeharder
Update dev dependency eslint (#4762)
3f84826 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Oct 7, 2019
@mikeharder
Update dev dependency eslint (#4762)
6416e17 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Oct 7, 2019
@mikeharder
Update dev dependency eslint (#4762)
dab7294 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Oct 7, 2019
@mikeharder
Update dev dependency eslint (#4762)
7236c5a 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Oct 7, 2019
@mikeharder
Update dev dependency eslint (#4762)
2a45501 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Oct 7, 2019
@mikeharder
Update dev dependency eslint (#4762)
3970f4b 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Oct 7, 2019
@mikeharder
Update dev dependency eslint (#4762)
8457850 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Oct 7, 2019
@mikeharder
Update dev dependency eslint (#4762)
fadc106 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Oct 17, 2019
@mikeharder
Update dev dependency eslint (#4762)
94deaa2 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
openapi-sdkautomation bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-js Oct 18, 2019
@mikeharder
Update dev dependency eslint (#4762)
84b9b36 
- Replaces eslint-detailed-reporter with built-in html formatter, since eslint-detailed-reporter is not compatible with eslint@6
- eslint-detailed-reporter is slightly nicer (since it shows the relevant source code for each error), but the built-in html formatter is sufficient
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiaoningLiu XiaoningLiu XiaoningLiu approved these changes

@KarishmaGhiya KarishmaGhiya KarishmaGhiya approved these changes

@ShivangiReja ShivangiReja ShivangiReja approved these changes

@chradek chradek Awaiting requested review from chradek

@daviwil daviwil Awaiting requested review from daviwil

@HarshaNalluru HarshaNalluru Awaiting requested review from HarshaNalluru

@jeremymeng jeremymeng Awaiting requested review from jeremymeng

@jiacfan jiacfan Awaiting requested review from jiacfan

@sophiajt sophiajt Awaiting requested review from sophiajt

@ramya-rao-a ramya-rao-a Awaiting requested review from ramya-rao-a

@sadasant sadasant Awaiting requested review from sadasant

@vinjiang vinjiang Awaiting requested review from vinjiang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikeharder @XiaoningLiu @KarishmaGhiya @ShivangiReja