[Storage] verify errors for tests that expect errors #5242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests currently do not verify expected errors properly. They just catch the error then pass the tests. The problem is `assert.fail()` in the `try`-block also throws error. Assertion error is swallowed if we don't check the caught error. This change adds verification for the expected errors.
jeremymeng
requested review from
HarshaNalluru,
jiacfan,
vinjiang and
XiaoningLiu
as code owners
|
Build failed. Might need to update the recordings for specific aborter tests. |
|
/check-enforcer reset |
|
/check-enforcer queued |
|
/check-enforcer evaluate |
|
/check-enforcer inprogress |
XiaoningLiu
added
Client
XiaoningLiu
approved these changes
Sep 25, 2019
I recorded a new baseline. The diff is only in the container name. |
jeremymeng
force-pushed
the
check-abort-error
branch
2 times, most recently
from
047434d
to
c7ccdb9
Compare
jeremymeng
force-pushed
the
check-abort-error
branch
from
c7ccdb9
to
b504b8e
Compare
HarshaNalluru
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests currently do not verify expected errors properly. They just catch the
error then pass the tests. The problem is
assert.fail()in thetry-blockalso throws error. Assertion error is swallowed if we don't check the caught
error.
This change adds verification for the expected errors.
Resolves #4580