[Storage][Queue] re-export models used in public api surface ex… #5534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremymeng
requested review from
HarshaNalluru,
jiacfan,
vinjiang and
XiaoningLiu
as code owners
|
/azp run js - storage-queue - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
XiaoningLiu
reviewed
Oct 15, 2019
Before this change we don't even have links to the generated models due to a
After this change, the links are generated. |
jeremymeng
force-pushed
the
queue-model-import
branch
2 times, most recently
from
f817c6a
to
a4a38fc
Compare
jeremymeng
added
Client
XiaoningLiu
approved these changes
Oct 18, 2019
jeremymeng
force-pushed
the
queue-model-import
branch
from
a4a38fc
to
87bb50c
Compare
jeremymeng
force-pushed
the
queue-model-import
branch
from
87bb50c
to
bac6cdf
Compare
jeremymeng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces import * as Model with explicitly importing types that we used in public api surface. A geneartedModels.ts is added to import those types aliased with Model suffix to indicate that they are from generated models.
This change brings several benefits, among them
Some re-exported types are not aliased because they are used in the definition of the Models in generated code thus cannot be renamed.