[core-http] throw AbortError on request cancellation #5663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviwil
approved these changes
Oct 18, 2019
ramya-rao-a
approved these changes
Oct 18, 2019
joheredi
reviewed
Oct 18, 2019
joheredi
approved these changes
Oct 18, 2019
chradek
requested review from
HarshaNalluru,
jeremymeng,
jiacfan,
vinjiang and
XiaoningLiu
as code owners
bterlson
requested changes
Oct 18, 2019
ramya-rao-a
reviewed
Oct 19, 2019
|
@HarshaNalluru Does storage packages align to use AbortError too? |
ramya-rao-a
reviewed
Oct 21, 2019
ramya-rao-a
reviewed
Oct 21, 2019
chradek
force-pushed
the
core-http-abort-error
branch
from
2c9813f
to
3b939f3
Compare
|
@daviwil |
|
I'll take a look :) |
daviwil
approved these changes
Oct 21, 2019
|
/azp run js - storage-blob - tests |
|
/azp run js - storage-file - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - storage-queue - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
bterlson
approved these changes
Oct 21, 2019
|
The storage-file failures look like an existing issue. I'm seeing failures since Thursday (after the feature/storage branch was merged into master, which is when we saw the AbortError issue as well) |
yes, @XiaoningLiu . |
|
/azp run js - storage-file - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - storage-file - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5659
This puts us in accordance with our guidelines. See the linked issue for more details.