Remove body field from RestError Object in core-http Library #5670
+12
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarangan12
requested review from
HarshaNalluru,
jeremymeng,
jiacfan,
vinjiang and
XiaoningLiu
as code owners
|
/azp run js - core - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ramya-rao-a
approved these changes
Oct 19, 2019
ramya-rao-a
reviewed
Oct 19, 2019
| error.body = this._pollState.resource; | ||
| if (error.body) { | ||
| const innerError: any = error.body.error; | ||
| error.response.parsedBody = this._pollState.resource; |
There was a problem hiding this comment.
details seems appropriate to me.
There was a problem hiding this comment.
On second thoughts this._pollState.resource has already been updated to parsed response body elsewhere, so this is ok for now, but needs deeper investigation. Opened issue #5680
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per recent conversation with @ramya-rao-a I am removing the body field from RestError Object in core-http Library. If required, this can be read from the response object.
Additional details:
With #5437,
responseproperty on the error will now have the parsed body & headers along with raw body & headers that it already had.detailsproperty on the error will have the shape/data model as defined in swagger for errorsWith these changes, the
bodyproperty on theRestErroritself becomes redundant.