-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage] Re-generate autorest with version 5.0.1 #5688
Conversation
@XiaoningLiu, @jiacfan This PR is the last step towards fixing the bug #4999 |
Thanks Ramya, I have updated Blob, Queue and File tests to check for the |
@XiaoningLiu, @jiacfan With this PR, users will now see a new field If we want to pull this error code up one level so that it can be directly on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a great progress! details.errorCode deserialized from HTTP response header x-ms-error-code right?
BTW, does Response body get deserialized too with the fix? Better to take a look at the deserialization for response body. Believe swagger defines schema for error body too.
For example, https://docs.microsoft.com/en-us/rest/api/storageservices/status-and-error-codes2
<Error>
<Code>string-value</Code>
<Message>string-value</Message>
</Error>
Yes
@sarangan12 Can you answer the above question? |
Actually, yes. The response body also gets deserialized and is accessible via |
Regenerating autorest with @microsoft.azure/autorest.typescript@5.0.1