Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[storage-queue] add missing jsdocs & export types that were missed out #5861

Merged
merged 5 commits into from
Oct 28, 2019
Merged

[storage-queue] add missing jsdocs & export types that were missed out #5861

merged 5 commits into from
Oct 28, 2019

Conversation

chradek
Copy link
Contributor

@chradek chradek commented Oct 27, 2019 •
edited
Loading

This time I did not add JSDoc comments for the generated types!

I did prefix the RetryPolicyFactory-related types with StorageQueue based on discussion here:
#5857 (comment)
I reverted the renames and will put those in a separate PR.

@HarshaNalluru HarshaNalluru added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) labels Oct 27, 2019
@ramya-rao-a
Copy link
Contributor

Waiting for review from @XiaoningLiu and/or @jiacfan

@ramya-rao-a ramya-rao-a changed the title [storage-queue] add jsdocs [storage-queue] add missing jsdocs & export types that were missed out Oct 27, 2019
XiaoningLiu
XiaoningLiu approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@XiaoningLiu XiaoningLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@chradek chradek merged commit b6759d1 into Azure:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramya-rao-a ramya-rao-a ramya-rao-a approved these changes

@HarshaNalluru HarshaNalluru HarshaNalluru approved these changes

@XiaoningLiu XiaoningLiu XiaoningLiu approved these changes

@bterlson bterlson bterlson approved these changes

@jeremymeng jeremymeng Awaiting requested review from jeremymeng

@jiacfan jiacfan Awaiting requested review from jiacfan

@vinjiang vinjiang Awaiting requested review from vinjiang

Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chradek @ramya-rao-a @bterlson @XiaoningLiu @HarshaNalluru