[storage] Storage policy renames #5862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chradek
requested review from
HarshaNalluru,
jeremymeng,
jiacfan,
vinjiang and
XiaoningLiu
as code owners
HarshaNalluru
added
Client
ramya-rao-a
approved these changes
Oct 27, 2019
chradek
commented
Oct 28, 2019
XiaoningLiu
reviewed
Oct 28, 2019
| * @implements {RequestPolicyFactory} | ||
| */ | ||
| export class RetryPolicyFactory implements RequestPolicyFactory { | ||
| private retryOptions?: RetryOptions; | ||
| export class StorageRetryPolicyFactory implements RequestPolicyFactory { |
There was a problem hiding this comment.
StorageRetryPolicyFactory [](start = 13, length = 25)
Rename the file name too. Like RetryPolicyFactory.ts => StorageRetryPolicyFactory.ts
We have practices to align the file name with the class name in it.
There was a problem hiding this comment.
@XiaoningLiu The policy files have been renamed too. Please take another look
bterlson
approved these changes
Oct 28, 2019
|
FWIW rebasing this will make the api report more accurate. Might be good to double-check that before merging. |
XiaoningLiu
approved these changes
Oct 28, 2019
|
/azp run js - storage-blob - tests |
|
/azp run js - storage-queue - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - storage-file - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - storage-file - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames the storage exported policy factories and related symbols with the
Storageprefix.