Add AuthFileCredential and its unit test to identity #7031
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellismg
requested changes
Jan 21, 2020
sdk/identity/identity/src/credentials/clientSecretCredential.ts
Outdated
Show resolved
Hide resolved
schaabs
reviewed
Feb 4, 2020
sdk/identity/identity/src/credentials/authFileCredential.browser.ts
Outdated
Show resolved
Hide resolved
schaabs
reviewed
Feb 4, 2020
schaabs
reviewed
Feb 4, 2020
|
@jonathandturner @schaabs - Can you help get us to sign off for April release? Thanks, Jon |
|
This is on hold pending further discussion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following Azure/azure-sdk-for-net#9312, I add the AuthFileCredential in JS and its unit test. However, the unit test “SdkAuthFileEnsureCredentialParsesCorrectly” in C# is not completed. In this unit test of C#, it uses reflection to get the private field "_credential" which type is TokenCredential. Finally, casting the type TokenCredential to type ClientSecretCredential by using"as", then get the property "clientId","tenantId" and "clientSecret" to authenticate. We can't use reflection to do the similar things and don't have the convertion from parent class to child class like C#.