-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TypeScript to 3.8 #8659
Update TypeScript to 3.8 #8659
Conversation
CI failure look like a bad tsconfig in cosmos:
|
@xirzec Feel free to remove |
Looks good. Add Storage label for service attention. |
Now cosmos legs are complaining about |
Can you retry the tests? That's the emulator failing to start. No idea why it would fail with that error. Possible it got run on some agent that didn't have that exe. Strange, but not without precedent to get a weird agent. |
/cc - @danieljurek for the emulator issue. |
Update - [Issue is caused by running the PowerShell commands to get the emulator to execute the samples in a Linux VM as a separate "Job", #8689 removes that separate-samples-job since the samples are already being executed as part of the Tests-Job] |
This PR catches us up to TS 3.8 since 3.9 is due out soon. I will merge this after we release for May.