Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TypeScript to 3.8 #8659

Merged
merged 3 commits into from
May 7, 2020
Merged

Update TypeScript to 3.8 #8659

merged 3 commits into from
May 7, 2020

Conversation

xirzec
Copy link
Member

@xirzec xirzec commented May 1, 2020

This PR catches us up to TS 3.8 since 3.9 is due out soon. I will merge this after we release for May.

@xirzec
Copy link
Member Author

xirzec commented May 1, 2020

CI failure look like a bad tsconfig in cosmos:

samples/tsconfig.json(3,5): error TS5053: Option 'noEmit' cannot be specified with option 'composite'

@southpolesteve
Copy link
Contributor

@xirzec Feel free to remove composite from samples tsconfig.json if that fixes it. Honestly sort of regret splitting up our package into TS projects. Its been a headache. Invoking the TS compiler 3 different times was not terribly slow.

@jeremymeng jeremymeng added the Storage Storage Service (Queues, Blobs, Files) label May 4, 2020
@jeremymeng
Copy link
Member

Looks good. Add Storage label for service attention.

@xirzec
Copy link
Member Author

xirzec commented May 4, 2020

Now cosmos legs are complaining about msiexec not being a valid command. @southpolesteve any clue as to what needs to happen here?

@southpolesteve
Copy link
Contributor

Can you retry the tests? That's the emulator failing to start. No idea why it would fail with that error. Possible it got run on some agent that didn't have that exe. Strange, but not without precedent to get a weird agent.

@HarshaNalluru
Copy link
Member

/cc - @danieljurek for the emulator issue.

@HarshaNalluru
Copy link
Member

HarshaNalluru commented May 4, 2020

Update -
@danieljurek opened a PR #8689 for to fix the issue.

[Issue is caused by running the PowerShell commands to get the emulator to execute the samples in a Linux VM as a separate "Job", #8689 removes that separate-samples-job since the samples are already being executed as part of the Tests-Job]

@xirzec xirzec merged commit b9446b8 into Azure:master May 7, 2020
@xirzec xirzec deleted the ts3.8 branch May 7, 2020 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants