Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KeyVault Secrets Hotfix 4.0.3] Addressing the challenge authentication cache bug #8766

Merged
merged 6 commits into from
May 13, 2020
Merged

[KeyVault Secrets Hotfix 4.0.3] Addressing the challenge authentication cache bug #8766

merged 6 commits into from
May 13, 2020

Conversation

sadasant
Copy link
Contributor

@sadasant sadasant commented May 7, 2020 •
edited
Loading

This PR highlights the changes needed to release the hotfix that resolves an issue reported by a customer: #8378

The PR to master is: #8558

Related to:

@sadasant sadasant requested review from sophiajt and ramya-rao-a May 7, 2020 13:18
@sadasant sadasant self-assigned this May 7, 2020
@sadasant sadasant changed the title [HOTFIX] [KeyVault-Secrets] Addressing the challenge authentication cache bug [HOTFIX] [KeyVault-Secrets] [v4.0.3] Addressing the challenge authentication cache bug May 7, 2020
@sadasant sadasant force-pushed the hotfix/keyvault-challengeAuth-keys-secrets-4.0.3-secrets branch from 5ce78a7 to 208bc1f Compare May 7, 2020 16:10
@sadasant sadasant changed the title [HOTFIX] [KeyVault-Secrets] [v4.0.3] Addressing the challenge authentication cache bug [WIP] [HOTFIX] [KeyVault-Secrets] [v4.0.3] Addressing the challenge authentication cache bug May 7, 2020
@sadasant
Copy link
Contributor Author

sadasant commented May 7, 2020

The diff in this PR will get scrambled for a bit.

@sadasant sadasant force-pushed the hotfix/keyvault-challengeAuth-keys-secrets-4.0.3 branch from 295258c to 51851a1 Compare May 7, 2020 22:31
@sadasant sadasant marked this pull request as draft May 7, 2020 22:33
@sadasant sadasant mentioned this pull request May 7, 2020
Merged
@sadasant
Copy link
Contributor Author

sadasant commented May 7, 2020

This PR will go back to normal after this is merged: #8782

@sadasant sadasant changed the title [WIP] [HOTFIX] [KeyVault-Secrets] [v4.0.3] Addressing the challenge authentication cache bug [WIP] [KeyVault Secrets Hotfix 4.0.3] Addressing the challenge authentication cache bug May 7, 2020
This was referenced May 7, 2020
Merged
Merged
@sadasant sadasant force-pushed the hotfix/keyvault-challengeAuth-keys-secrets-4.0.3-secrets branch from 208bc1f to 9e3a4a5 Compare May 7, 2020 23:50
@sadasant
Copy link
Contributor Author

sadasant commented May 7, 2020

I cleaned up this branch. This PR will pass once these PRs are merged:

#8782
#8783

@sadasant sadasant changed the title [WIP] [KeyVault Secrets Hotfix 4.0.3] Addressing the challenge authentication cache bug [KeyVault Secrets Hotfix 4.0.3] Addressing the challenge authentication cache bug May 8, 2020
@sadasant
Copy link
Contributor Author

sadasant commented May 9, 2020 •
edited
Loading

@ramya-rao-a Hi!

Even though this is merged: #8782
This PR still needs the recordings merged, which I've separated here: #8783

I separated the recording because of how much noise they add to the actual PRs with the hotfix.
The recordings PR by itself will fail, but it should only fail for the relevant projects (keys and secrets). After that is merged, this PR should go green. The idea is that we will be able to review what matters the most here.

@sophiajt
Copy link
Contributor

This is looking good. What's left on the TODO? (I see it's still a draft)

@sadasant sadasant force-pushed the hotfix/keyvault-challengeAuth-keys-secrets-4.0.3-secrets branch from 9448f03 to c912edb Compare May 11, 2020 19:18
@sadasant sadasant marked this pull request as ready for review May 11, 2020 19:18
@sadasant
Copy link
Contributor Author

CI is getting out of memory, or hitting timeouts. I need to follow up with Karishma.

ramya-rao-a
ramya-rao-a suggested changes May 12, 2020
View reviewed changes
Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting review to "Request changes" until changelog is updated as per the feedback in #8766 (comment) and the date change

@sadasant
Copy link
Contributor Author

We need to either merge this PR, or the keys one, to see CI go green.

ramya-rao-a
ramya-rao-a approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait on approval from @jonathandturner before merging

@sadasant sadasant mentioned this pull request May 13, 2020
Merged
@sadasant sadasant requested a review from mikeharder as a code owner May 13, 2020 00:10
@sadasant sadasant force-pushed the hotfix/keyvault-challengeAuth-keys-secrets-4.0.3-secrets branch from cbfa373 to d63b172 Compare May 13, 2020 00:13
@sadasant
Copy link
Contributor Author

@ramya-rao-a I had to rebase over the base branch. I tried to merge the base branch in but this got into a weird state. I hope is not too much of a problem, the commits are the same.

@ramya-rao-a
Copy link
Contributor

Looks good, am guessing this is the PR CI that should go all green, now that everything else has made it to the hot fix branch?

@sadasant
Copy link
Contributor Author

It all went green effectively! I'll merge.

@sadasant sadasant merged commit 28efa2e into Azure:hotfix/keyvault-challengeAuth-keys-secrets-4.0.3 May 13, 2020
@sadasant sadasant deleted the hotfix/keyvault-challengeAuth-keys-secrets-4.0.3-secrets branch May 13, 2020 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramya-rao-a ramya-rao-a ramya-rao-a approved these changes

@sophiajt sophiajt sophiajt approved these changes

@bterlson bterlson Awaiting requested review from bterlson

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya

@mikeharder mikeharder Awaiting requested review from mikeharder

Assignees

@sadasant sadasant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sadasant @sophiajt @ramya-rao-a